[Kimchi-devel] [PATCH] [Wok] Bug fix: Add space to separate class names

[Daniel Henrique Barboza]

Reviewed-by: Daniel Barboza <dhbarboza82 at gmail.com>
Tested-by: Daniel Barboza <dhbarboza82 at gmail.com>
Liked-by: Daniel Barboza <dhbarboza82 at gmail.com>


On 05/13/2016 04:52 PM, Aline Manera wrote:
> Commit d4b0c5, added the following:
>
> 'data-converter=' + fields[i]["converter"] : ''
>
> but as it is string concatenation, we need to add an space before
> "data-converter" to do not wrongly merge strings.
>
> ' data-converter=' + fields[i]["converter"] : '',
>
> This turns back the plugin color when displaying user log activity.
>
> Signed-off-by: Aline Manera <alinefm at linux.vnet.ibm.com>
> ---
>   ui/js/wok.bootgrid.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/js/wok.bootgrid.js b/ui/js/wok.bootgrid.js
> index c4082dd..7d634bb 100644
> --- a/ui/js/wok.bootgrid.js
> +++ b/ui/js/wok.bootgrid.js
> @@ -50,7 +50,7 @@ wok.createBootgrid = function(opts) {
>   
>     for (var i = 0; i < fields.length; i++) {
>       var columnHtml = [
> -      '<th data-type="', fields[i]["type"], '" data-column-id="', fields[i]["column-id"], '"', (fields[i].identifier) ? 'data-identifier="true"' : '', ("header-class" in fields[i]) ? 'data-header-css-class="gridHeader ' + fields[i]["header-class"] + '"' : 'gridHeader', ("data-class" in fields[i]) ? ' data-align="' + fields[i]["data-class"] + '"' + ' headerAlign="center"' : ' data-align="left" headerAlign="center"', ("formatter" in fields[i]) ? 'data-formatter=' + fields[i]["formatter"] : '', (fields[i].width) ? (' data-width="' + fields[i].width + '"') : '', ("converter" in fields[i]) ? 'data-converter=' + fields[i]["converter"] : '',
> +      '<th data-type="', fields[i]["type"], '" data-column-id="', fields[i]["column-id"], '"', (fields[i].identifier) ? 'data-identifier="true"' : '', ("header-class" in fields[i]) ? 'data-header-css-class="gridHeader ' + fields[i]["header-class"] + '"' : 'gridHeader', ("data-class" in fields[i]) ? ' data-align="' + fields[i]["data-class"] + '"' + ' headerAlign="center"' : ' data-align="left" headerAlign="center"', ("formatter" in fields[i]) ? 'data-formatter=' + fields[i]["formatter"] : '', (fields[i].width) ? (' data-width="' + fields[i].width + '"') : '', ("converter" in fields[i]) ? ' data-converter=' + fields[i]["converter"] : '',
>         '>', ("title" in fields[i]) ? fields[i]["title"] : fields[i]["column-id"],
>         '</th>'
>       ].join('');