[Kimchi-devel] [PATCH] [Kimchi] [RFC] Storave Volume management UI

[Aline Manera]

Hi Samuel,

Overall comments:

1. As you added the "Create" options under storage volume (which I think 
it is best to be done), please, remove the "Add volume" option from 
storage pool level.

2. When no storage volume is selected, only "Create" option should be 
enabled.

3. When one storage volume is selected, disable "Create" option and 
enable "Wipe", "Resize", "Clone" and "Delete".

4. When more than on storage volume are selected, disable "Create", 
"Resize", "Clone" and enable "Wipe" and "Delete".

5. Filter is not working (maybe it is intentional as it is an RFC)

6. "Wipe" and "Delete" should display a confirmation box.

7. "Resize" should open a new dialog to get the new storage volume size.

8. I don't think we need anything for Clone. The operation should be 
atomic. No input is needed.
     It will return a Task to be tracked. We need to do something 
similar to what we have for VM cloning. Display a fake storage volume 
entry with a loading icon and "Cloning" label.

9. The create dialog should be what we have today for "Add volume" in 
the storage pool level with one more option "Capacity" to create a new 
empty storage volume given a size.
     It will return a Task to be tracked as well. And we should follow 
the same behavior while cloning.

I will review the patch soon and provide any feedback inline there.

Regards,
Aline Manera

On 05/13/2016 06:39 PM, sguimaraes943 at gmail.com wrote:
> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>
> This patch adds the UI for Storage Volume management action button, filter input, gallery view and gallery / list view toggle-switch button with multi-selection enabled.
>
> This is just the initial patch for the UI to get feedback, will add Storage Volume modal and confirm windows and map create, delete, resize, wipe and clone actions in the next commit.
>
> Samuel Guimarães (1):
>    Storave Volume management UI
>
>   ui/css/kimchi.css                | 266 +++++++++++++++++++++++++++++-------
>   ui/css/src/modules/_storage.scss | 287 +++++++++++++++++++++++++++++++++------
>   ui/js/src/kimchi.storage_main.js |  82 +++++------
>   ui/pages/tabs/storage.html.tmpl  | 121 +++++++++++------
>   4 files changed, 576 insertions(+), 180 deletions(-)
>