[Kimchi-devel] [PATCH] [Kimchi] [RFC] Storave Volume management UI

[Aline Manera]

On 05/16/2016 05:01 PM, Samuel Henrique De Oliveira Guimaraes wrote:
>
> -----Original Message-----
> From: kimchi-devel-bounces at ovirt.org [mailto:kimchi-devel-bounces at ovirt.org] On Behalf Of Aline Manera
> Sent: segunda-feira, 16 de maio de 2016 15:06
> To: sguimaraes943 at gmail.com; Kimchi Devel <kimchi-devel at ovirt.org>
> Subject: Re: [Kimchi-devel] [PATCH] [Kimchi] [RFC] Storave Volume management UI
>
> Hi Samuel,
>
> Overall comments:
>
> 1. As you added the "Create" options under storage volume (which I think it is best to be done), please, remove the "Add volume" option from storage pool level.
> -I'll remove the Create from the Volume drop-down and keep the other one.

It is better to have all the storage volume centralized in one place.
So as we are going to support storage volume actions, I'd rather to have 
the Create option listed there instead of on storage pool level (as it 
is today).
Do you think it is possible to do that?

> 2. When no storage volume is selected, only "Create" option should be enabled.
> -Will disable the drop-down by default
>
> 3. When one storage volume is selected, disable "Create" option and enable "Wipe", "Resize", "Clone" and "Delete".
> -See above.


> 4. When more than on storage volume are selected, disable "Create", "Resize", "Clone" and enable "Wipe" and "Delete".
>  From the API, I can see that Clone has some optional parameters. I'm still going to investigate the best approach to keep track of the cloning volumes but I think we could clone more than one item at once. It may get extremely slow due to several tasks running at the same time...

Yeap! We can have clone enabled for multiple selection as well.

> 5. Filter is not working (maybe it is intentional as it is an RFC)
> Yes, the filter is currently not working. In fact I'm facing some issues with the filter using list.js once the volumes list gets refreshed.
>
> 6. "Wipe" and "Delete" should display a confirmation box.
> For now I'm displaying the array of selected volumes but sometimes it turns into a huge list. Should we change it to just a regular confirmation box saying that it will wipe/delete all the selected data?

I prefer to keep showing the storage volume names instead of a generic 
message.
It is already happened to me to delete a wrong VM because the 
confirmation box did not shown me which VM I was deleting.

> 7. "Resize" should open a new dialog to get the new storage volume size.
> Ok.
>
> 8. I don't think we need anything for Clone. The operation should be atomic. No input is needed.
>       It will return a Task to be tracked. We need to do something similar to what we have for VM cloning. Display a fake storage volume entry with a loading icon and "Cloning" label.
> I'll see what I can do with the "fake" item but I think this is going to take more time than I was expecting. As for the parameters, the API.md has:

The 'fake' item is already created when using the "Add Volume" option. 
You just need to reuse it overall when needed.
Because that, I also think it is better to move the "Add Volume" to the 
Create option inside the storage volume view.

> * clone: Clone a Storage Volume.
>      * pool: The name of the destination pool (optional).
>      * name: The new storage volume name (optional).
>
> Shouldn't it have a modal window?

No! No model window is needed.

The 'pool' is the storage pool related to the storage volumes listed.
When you access the Storage tab, you have the list of all storage pools. 
When accessing the details for a given storage pool, you get the storage 
volumes.
When creating or cloning a storage volume, the storage pool linked to it 
must be used.
So for the clone specific case, get the storage pool related to the 
storage volume section and keep the new name optional, that way the 
backend will automatically get one.

For example, if I have a volume named "my-volume" in a "MyVols" pools 
and I want to clone it, the API will be:

POST /storagepools/MyVols/my-volume/clone

ie, POST /storagepools/<pool-name>/<storage-volume>/clone

Does that make sense?


>
> 9. The create dialog should be what we have today for "Add volume" in the storage pool level with one more option "Capacity" to create a new empty storage volume given a size.
>       It will return a Task to be tracked as well. And we should follow the same behavior while cloning.
> Ok. I'll move this as top priority once I finish wipe and filter (Delete is almost done but facing a minor issue when only one volume is available - The list won't update with empty results)
>
> I will review the patch soon and provide any feedback inline there.
>
> Regards,
> Aline Manera
>
> On 05/13/2016 06:39 PM, sguimaraes943 at gmail.com wrote:
>> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>>
>> This patch adds the UI for Storage Volume management action button, filter input, gallery view and gallery / list view toggle-switch button with multi-selection enabled.
>>
>> This is just the initial patch for the UI to get feedback, will add Storage Volume modal and confirm windows and map create, delete, resize, wipe and clone actions in the next commit.
>>
>> Samuel Guimarães (1):
>>     Storave Volume management UI
>>
>>    ui/css/kimchi.css                | 266 +++++++++++++++++++++++++++++-------
>>    ui/css/src/modules/_storage.scss | 287 +++++++++++++++++++++++++++++++++------
>>    ui/js/src/kimchi.storage_main.js |  82 +++++------
>>    ui/pages/tabs/storage.html.tmpl  | 121 +++++++++++------
>>    4 files changed, 576 insertions(+), 180 deletions(-)
>>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel