[Kimchi-devel] [PATCHv2] [Kimchi] Edit Virtual Network with passthrough support

[Lucio Correia]

On 20-05-2016 11:44, Socorro Stoppler wrote:
>
>
> On 05/20/2016 06:42 AM, Lucio Correia wrote:
>> Hi Socorro,
>>
>> On 19-05-2016 19:54, Socorro Stoppler wrote:
>>> v2:
>>> - Fixed bugs encountered while testing
>>> - Added support for macvtap passthrough
>>> - Addressed feedback from Lucio
>>> - UI issues below are still unresolved
>>>    - Due to value from backend currently is not showing up when edit
>>> comes up and instead
>>>      'Nothing selected' is showing, this is being handled gracefully
>>> in that if user leaves
>>>      the Destination field as is, the value (from backend) is preserved.
>> I'm fine with this solution as definitive. If user changes it, you
>> pass the parameter, otherwise not. Returning the nic in the backend
>> may add confusion, since a bridged connection will be using a bridge
>> interface based on that nic, not the nic itself.
>>
>> More comments below (only about TODOs in the code).
> Both TODOs will need to be modified or taken out to address UI issues.
> Just wanted to make a note in the code and if anybody has any ideas on
> these issues
> and can help out, it's obvious where they need to be addressed.  Any
> takers?  :-)

After testing it on a system with two nics (ens3 and ens7), I found the 
following issues:

For bridged networks:

- With VLAN ID:
edit works fine, both ens3 and ens7 are showed in the destination 
drop-down. Only issue here is that it preselects always the same ens7, 
even if ens3 is the one being used by the network. ens3 should be 
selected in that case.

- Without VLAN ID:
only the nic not in use (ens3) is showed in the Destination drop-down, 
user is forced to change to it. In this case ens7 should be showed and 
preselected. This problem also happens for macvtap networks.

For VEPA and Passthrough networks (multiple interfaces):
- When the network contains only one interface (ens7), "Nothing 
selected" is showed in addition to nics not in use (ens3). It should 
show ens7 (preselected) instead of "Nothing selected".
- When both ens7 and ens3 are part of the network, it shows only 
"Nothing selected", and user is not allowed to change it to have only 
ens3 or ens7. It should show both as preselected, instead of "Nothing 
selected".
- Other issue not related to this patch: Virtualization->Network tab 
lists only one of the interfaces in the table, instead of all of them.


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil