[Kimchi-devel] [PATCH v4] [Kimchi] Storage Volume management

[Aline Manera]

Hi Samuel,

Some comments:

1. When I switch to the "Gallery view" I can see all volumes selected 
and after one second, they are deselected

2. When you select multiple volumes to perform an action, there is no 
feedback to user that an operation will be done on those selected volumes.
     I can select others, deselect the ones I have selected before and 
so. We should block the volume selected, add a loading icon, for 
example, and a mark check when the operation is completed.

3. Usually we don't use success messages on Wok and its plugins. Any 
reason to add them now?

4. The message are duplicated. I can see 2 messages when trying to 
delete multiple items "Volume selected were deleted" + "Volume X was 
successfully deleted".

5. The same messages for delete operation are shown when I wipe volumes.

6. The wipe operation will change the allocation value and so it must be 
updated in the volume box.

7. The scroll bar should only scroll the volumes. It is hard to get back 
all time to have the Actions menu available.

I think that is all from my side.

Regards,
Aline Manera

On 05/23/2016 12:46 PM, sguimaraes943 at gmail.com wrote:
> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>
> This patch adds Storage Volume management functions Wipe, Clone, Resize and Delete with multiple selection. It also includes a filter input for each Storage Pool and Gallery View for Storage Volumes.
>
> Changes from [RFC] version:
>
> v1:
>   - HTML and CSS
>
> v2:
>   - Delete and Wipe with multi-selection
>   - Confirm messages with list of selected volumes when wiping or deleting volumes (requires SCSS/CSS patch sent to Wok)
>   - Filter working
>   - Removed "Add Volume" link from Storage Pool action button
>   - Added "Add Volume" to Volume box action button
>
> v3:
>   - Clone function working with multiple selection
>   - Progress bar working for clone and create volume
>   - Temporary volume added to the volumes when cloning
>   - Seamless refresh on the volumes once each task is finished
>   - Fixed issue when list wouldn't refresh when all volumes are removed from the storage pool.
>
> v4:
>   - Prevent scroll when Drop-down in volumes list is clicked
>   - Dropdown is not clipped from volumes list when there's only one or two items on the list
>   - Added Media Queries for small screen resolutions
>
> Samuel Guimarães (1):
>    Storage Volume management
>
>   model/storagevolumes.py                            |   2 +-
>   ui/css/kimchi.css                                  | 369 ++++++++++++++--
>   ui/css/src/modules/_storage.scss                   | 347 ++++++++++++---
>   ui/js/src/kimchi.api.js                            |  50 +++
>   ui/js/src/kimchi.storage_main.js                   | 465 +++++++++++++++++----
>   ui/js/src/kimchi.storagepool_add_volume_main.js    |   2 +-
>   ui/js/src/kimchi.storagepool_resize_volume_main.js |  59 +++
>   ui/pages/i18n.json.tmpl                            |   6 +
>   ui/pages/storagepool-resize-volume.html.tmpl       |  51 +++
>   ui/pages/tabs/storage.html.tmpl                    | 155 +++----
>   10 files changed, 1249 insertions(+), 257 deletions(-)
>   create mode 100644 ui/js/src/kimchi.storagepool_resize_volume_main.js
>   create mode 100644 ui/pages/storagepool-resize-volume.html.tmpl
>