[Kimchi-devel] [PATCH] [Kimchi 0/4] CPU Hot plug/unplug feature

[Lucio Correia]

Looks good. Only a comment in first patch.

Reviewed-By: Lucio Correia <luciojhc at linux.vnet.ibm.com>

On 08/11/2016 09:49, dhbarboza82 at gmail.com wrote:
> From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>
> This patch set implements CPU Hot plug/unplug capabilities
> in Kimchi.
>
> To test it, simply add/remove CPUs in a running guest via the
> 'Edit' menu. Note that all restrictions on the current CPU value
> (can't exceed max number of CPUs, must be a number that makes
> sense in the topology if one is set) still applies.
>
> For Power systems, the hot unplug requires additional software
> running in the guest to work: powerpc-utils, ppc64-diag and
> librtas. The service 'rtas_err' must be running too.
>
>
> Further enhancements and bug fixes in the CPU handling when
> editing a turned off VM (such as #1042) will be send in a
> separated patch.
>
>
>
> Daniel Henrique Barboza (4):
>   CPU Hot plug/unplug: i18n changes
>   CPU Hot plug/unplug: model changes
>   CPU Hot plug/unplug: test changes
>   CPU Hot plug/unplug: ui changes
>
>  i18n.py                             |  5 +++
>  model/vms.py                        | 50 ++++++++++++++++++++++-
>  tests/test_model.py                 | 80 +++++++++++++++++++++++++++++++++++++
>  ui/js/src/kimchi.guest_edit_main.js | 12 +++---
>  ui/pages/guest-edit.html.tmpl       |  1 +
>  ui/pages/help/en_US/guests.dita     |  8 ++++
>  6 files changed, 148 insertions(+), 8 deletions(-)
>


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil