[Kimchi-devel] [PATCH] [Kimchi 6/7] Adding CPU setup help text in Edit Guest/Template
dhbarboza82 at gmail.com
dhbarboza82 at gmail.com
Wed Nov 23 15:45:13 UTC 2016
From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
This patch adds help texts in both dialogs to explain
the user the logic being used in the current CPU and
maximum CPU values.
Signed-off-by: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
---
ui/pages/guest-edit.html.tmpl | 8 ++++++++
ui/pages/template-edit.html.tmpl | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/ui/pages/guest-edit.html.tmpl b/ui/pages/guest-edit.html.tmpl
index 66e82ab..0aa2504 100644
--- a/ui/pages/guest-edit.html.tmpl
+++ b/ui/pages/guest-edit.html.tmpl
@@ -192,10 +192,18 @@
<div id="guest-processor">
<label for="vcpus">$_("Current CPU Number")</label>
<input id="vcpus" class="form-control" name="processor" type="number" min="1" />
+ <p class="help-block">
+ <i class="fa fa-info-circle"></i>
+ $_("Current CPU must be equal or lower than the Maximum CPU value. If a topology is set, it must be also be a multiple of the 'threads' value.")
+ </p>
</div>
<div id="guest-max-processor-panel" class="form-group">
<label for="guest-edit-max-processor-textbox">$_("Max CPU")</label>
<input id="guest-edit-max-processor-textbox" class="form-control" name="max-processor" type="number" min="1" />
+ <p class="help-block">
+ <i class="fa fa-info-circle"></i>
+ $_("If a topology is set, this value will be the product of sockets * times * cores.")
+ </p>
</div>
</div>
<div class="manual form-group">
diff --git a/ui/pages/template-edit.html.tmpl b/ui/pages/template-edit.html.tmpl
index 0939ad8..6e7f97b 100644
--- a/ui/pages/template-edit.html.tmpl
+++ b/ui/pages/template-edit.html.tmpl
@@ -156,10 +156,18 @@
<div id="guest-processor">
<label for="vcpus">$_("Current CPU Number")</label>
<input id="vcpus" class="form-control" name="processor" type="number" min="1" />
+ <p class="help-block">
+ <i class="fa fa-info-circle"></i>
+ $_("Current CPU must be equal or lower than the Maximum CPU value. If a topology is set, it must be also be a multiple of the 'threads' value.")
+ </p>
</div>
<div id="guest-max-processor-panel" class="form-group">
<label for="guest-edit-max-processor-textbox">$_("Max CPU")</label>
<input id="guest-edit-max-processor-textbox" class="form-control" name="max-processor" type="number" min="1" />
+ <p class="help-block">
+ <i class="fa fa-info-circle"></i>
+ $_("If a topology is set, this value will be the product of sockets * times * cores.")
+ </p>
</div>
</div>
<div class="manual form-group">
--
2.7.4
More information about the Kimchi-devel
mailing list