[Kimchi-devel] [PATCH] [Kimchi 0/2] Issue #998 Not all static strings are externalized

[Pooja Kulkarni]

Hi Aline,

The issues related to Templates and Networks was fixed by changes made 
to POTFILES.in, which is part of the patch.

Regards,
Pooja Kulkarni

On 10/14/2016 10:51 PM, Aline Manera wrote:
> Hi Pooja,
>
> Does this patch really fix all the issues mentioned on #998?
>
> I could not see any update related to Templates and Networks.
>
> If you want to send a patch to fix #998, please, fix all the problems 
> reported in the bug.
> Otherwise, do not include #998 in your commit message and give it an 
> more appropriated message.
>
> Regards,
> Aline Manera
>
>
> On 10/12/2016 06:22 AM, pkulkark at linux.vnet.ibm.com wrote:
>> From: Pooja Kulkarni <pkulkark at linux.vnet.ibm.com>
>>
>> This patch set externalizes all the
>> static string that should be externalized
>> to support globalization. Also contains
>> the updated .pot and .po files
>>
>> Pooja Kulkarni (2):
>>    Issue #998 Not all static strings are externalized
>>    Issue #998 Updated .pot and .po files
>>
>>   po/POTFILES.in                             |   1 +
>>   po/de_DE.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/en_US.po                                | 239 
>> +++++++++++++++++++++++++--
>>   po/es_ES.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/fr_FR.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/it_IT.po                                | 255 
>> +++++++++++++++++++++++++++--
>>   po/ja_JP.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/kimchi.pot                              | 239 
>> +++++++++++++++++++++++++--
>>   po/ko_KR.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/pt_BR.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/ru_RU.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/zh_CN.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   po/zh_TW.po                                | 254 
>> ++++++++++++++++++++++++++--
>>   ui/js/src/kimchi.guest_storage_add.main.js |  12 +-
>>   ui/js/src/kimchi.storagepool_add_main.js   |  12 +-
>>   ui/pages/guest-edit.html.tmpl              |  14 +-
>>   ui/pages/i18n.json.tmpl                    |  18 ++
>>   17 files changed, 2937 insertions(+), 139 deletions(-)
>>
>