[Kimchi-devel] [PATCH] [Kimchi] Issue #1060: Edit template/Guest for s390x, console drop down shows empty box along with virtio and sclp.

[Lucio Correia]

Reviewed-By: Lucio Correia <luciojhc at linux.vnet.ibm.com>

On 23/10/2016 13:20, archus at linux.vnet.ibm.com wrote:
> From: Archana Singh <archus at linux.vnet.ibm.com>
>
> For s390x, console can be either virtio or sclp. Cannot be blank.
> Hence this fix will remove empty box for console in edit template
> and edit guest UI panels.
>
> Signed-off-by: Archana Singh <archus at linux.vnet.ibm.com>
> ---
>  ui/pages/guest-edit.html.tmpl    | 1 -
>  ui/pages/template-edit.html.tmpl | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/ui/pages/guest-edit.html.tmpl b/ui/pages/guest-edit.html.tmpl
> index 88ccb10..0bf17c6 100644
> --- a/ui/pages/guest-edit.html.tmpl
> +++ b/ui/pages/guest-edit.html.tmpl
> @@ -74,7 +74,6 @@
>                  <div class="form-group" id="guest-console-panel" style="display:none;">
>                      <label for="guest-edit-console">$_("Console")</label>
>                      <select id="guest-edit-console" name="console" class="form-control">
> -                        <option value=""></option>
>                          <option value="sclp">$_("sclp")</option>
>                          <option value="virtio">$_("virtio")</option>
>                      </select>
> diff --git a/ui/pages/template-edit.html.tmpl b/ui/pages/template-edit.html.tmpl
> index 88454dc..e9a479e 100644
> --- a/ui/pages/template-edit.html.tmpl
> +++ b/ui/pages/template-edit.html.tmpl
> @@ -109,7 +109,6 @@
>                              </div>
>                              <div class="template-edit-wrapper-controls console" style="display:none">
>                                  <select id="template-edit-console" name="console" class="form-control">
> -                                    <option value=""></option>
>                                      <option value="sclp">$_("sclp")</option>
>                                      <option value="virtio">$_("virtio")</option>
>                                  </select>
>


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil