[Kimchi-devel] [PATCH V3] [Kimchi 0/2] Addition 'interfaces' parameter to template API.

[Archana Singh]

Hi Aline,

I sent V4 to only have interfaces returned by control/template.py 
specific to s390x/s390.

Thanks,

Archana Singh

On 09/01/2016 10:48 PM, Aline Manera wrote:
>
> I did a quick investigation and I noticed you are returning 
> 'interfaces' for x86 when it should be s390x specific
>
> [u'cdrom', u'cpu_info', u'disks', u'folder', u'graphics', u'icon', 
> *u'interfaces',* u'invalid', u'memory', u'name', u'networks', 
> u'os_distro', u'os_version']
> ['cdrom', 'cpu_info', 'disks', 'folder', 'graphics', 'icon', 
> 'invalid', 'memory', 'name', 'networks', 'os_distro', 'os_version']
>
>
> On 09/01/2016 02:13 PM, Aline Manera wrote:
>> Hi Archana,
>>
>> The tests are failing on x86 with those patches:
>>
>> ***** Running unit test: test_template...      FAILED
>> ======================================================================
>> FAIL: test_tmpl_lifecycle (test_template.TemplateTests)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>   File "test_template.py", line 113, in test_tmpl_lifecycle
>>     self.assertEquals(sorted(tmpl.keys()), sorted(keys))
>> AssertionError: Lists differ: [u'cdrom', u'cpu_info', u'disk... != 
>> ['cdrom', 'cpu_info', 'disks',...
>>
>> First differing element 6:
>> interfaces
>> invalid
>>
>> First list contains 1 additional elements.
>> First extra element 12:
>> os_version
>>
>> - [u'cdrom',
>> ?  -
>>
>> + ['cdrom',
>> -  u'cpu_info',
>> ?  -
>>
>> +  'cpu_info',
>> -  u'disks',
>> ?  -
>>
>> +  'disks',
>> -  u'folder',
>> ?  -
>>
>> +  'folder',
>> -  u'graphics',
>> ?  -
>>
>> +  'graphics',
>> -  u'icon',
>> ?  -
>>
>> +  'icon',
>> -  u'interfaces',
>> -  u'invalid',
>> ?  -
>>
>> +  'invalid',
>> -  u'memory',
>> ?  -
>>
>> +  'memory',
>> -  u'name',
>> ?  -
>>
>> +  'name',
>> -  u'networks',
>> ?  -
>>
>> +  'networks',
>> -  u'os_distro',
>> ?  -
>>
>> +  'os_distro',
>> -  u'os_version']
>> ?  -
>>
>> +  'os_version']
>>
>> ----------------------------------------------------------------------
>> Ran 5 tests in 20.021s
>>
>> FAILED (failures=1)
>>
>>
>> Could you verify that and resend the patches?
>>
>> Thanks,
>> Aline Manera
>>
>> On 09/01/2016 12:35 PM, archus at linux.vnet.ibm.com wrote:
>>> From: Archana Singh <archus at linux.vnet.ibm.com>
>>>
>>> 1) Code changes for additional param 'interfaces' to template API.
>>> 2) API.md changes for same.
>>>
>>> Archana Singh (2):
>>>    Updated code to support 'interfaces' parameter to template API 
>>> only on
>>>      s390x/s390 architecture.
>>>    Updated API.md for addition interfaces paramter in template API.
>>>
>>>   API.json              | 41 ++++++++++++++++++++++++++++++-
>>>   control/templates.py  |  1 +
>>>   docs/API.md           | 12 +++++++++
>>>   i18n.py               |  6 +++++
>>>   model/templates.py    | 17 +++++++++++++
>>>   osinfo.py             |  5 ++--
>>>   vmtemplate.py         | 20 +++++++++++++++
>>>   xmlutils/interface.py | 67 
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   8 files changed, 166 insertions(+), 3 deletions(-)
>>>
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160902/e5135fbb/attachment.html>