[Kimchi-devel] [PATCH][Kimchi] Issue #994: SPICE graphics does not need <channel> tag

[Aline Manera]

Hi Ramon,

Please, make sure to run 'make check' and 'make check-local' next times.

The 'make check-local' was failing with this patch. I fixed the issue 
and applied it.

Regards,
Aline Manera

On 09/02/2016 04:51 PM, Ramon Medeiros wrote:
> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
> ---
>   xmlutils/graphics.py | 14 +-------------
>   1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/xmlutils/graphics.py b/xmlutils/graphics.py
> index 5465bb8..4297c4f 100644
> --- a/xmlutils/graphics.py
> +++ b/xmlutils/graphics.py
> @@ -24,22 +24,10 @@ from lxml.builder import E
>   def get_graphics_xml(params):
>       """
>       <graphics type='%(type)s' autoport='yes' listen='%(listen)s'/>
> -
> -    - For spice graphics:
> -
> -    <channel type='spicevmc'>
> -      <target type='virtio' name='com.redhat.spice.0'/>
> -    </channel>
>       """
>       graphics = E.graphics(type=params['type'], autoport='yes',
>                             listen=params['listen'])
>       graphics_xml = ET.tostring(graphics, encoding='utf-8', pretty_print=True)
>
> -    if params['type'] == 'vnc':
> -        return graphics_xml
> +    return graphics_xml
>
> -    # For spice graphics, a channel also must be configured
> -    channel = E.channel(type='spicevmc')
> -    channel.append(E.target(type='virtio', name='com.redhat.spice.0'))
> -    channel_xml = ET.tostring(channel, encoding='utf-8', pretty_print=True)
> -    return graphics_xml + channel_xml