[Kimchi-devel] [PATCH] [Kimchi 3/4] Live migration RDMA support: ui changes

[Daniel Henrique Barboza]

On 01/10/2017 10:19 AM, Aline Manera wrote:
>
> Hi Daniel,
>
> I said in another occasion that if the VM does not have any network 
> card over RDMA the migration will fail if the user selects to use 
> RDMA, is that correct or I am misunderstanding something?
>
> If so, could you, please, add an information message with the RDMA 
> checkbox, informing user about that? Remember, Kimchi user does not 
> have deep knowleadge in virtualization so we need to guide him/her to 
> avoid mistakes.

I'll do that and send a v3!

>
> On 01/05/2017 03:41 PM, dhbarboza82 at gmail.com wrote:
>> From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>>
>> Added a new checkbox in ui/pages/guest-migration.html.tmpl, giving
>> the user the choice of enabling RDMA transport in the migration
>> process.
>>
>> Signed-off-by: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>> ---
>>   ui/js/src/kimchi.guest_livemigration.js | 7 ++++---
>>   ui/pages/guest-migration.html.tmpl      | 6 +++++-
>>   2 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/ui/js/src/kimchi.guest_livemigration.js 
>> b/ui/js/src/kimchi.guest_livemigration.js
>> index 613fd9e..d89deec 100644
>> --- a/ui/js/src/kimchi.guest_livemigration.js
>> +++ b/ui/js/src/kimchi.guest_livemigration.js
>> @@ -1,7 +1,7 @@
>>   /*
>>    * Project Kimchi
>>    *
>> - * Copyright IBM Corp, 2016
>> + * Copyright IBM Corp, 2016-2017
>>    *
>>    * Licensed under the Apache License, Version 2.0 (the "License");
>>    * you may not use this file except in compliance with the License.
>> @@ -80,13 +80,14 @@ kimchi.getLiveMigrationInputValues = function() {
>>       var username = $("#user").val();
>>       var password = $("#password").val();
>>       var toDelete = $("#deleteVM").prop('checked');
>> +    var enable_rdma = $("#enableRDMA").prop('checked');
>>       var data = {};
>>       data[kimchi.selectedGuest] = {
>>           values: {
>> -            remote_host: host
>> +            remote_host: host,
>> +            enable_rdma: enable_rdma
>>           },
>>           toDelete: toDelete
>> -
>>       };
>>       if (username && password) {
>>           data[kimchi.selectedGuest].values.user = username;
>> diff --git a/ui/pages/guest-migration.html.tmpl 
>> b/ui/pages/guest-migration.html.tmpl
>> index e2d3f25..a04f7c3 100644
>> --- a/ui/pages/guest-migration.html.tmpl
>> +++ b/ui/pages/guest-migration.html.tmpl
>> @@ -1,7 +1,7 @@
>>   #*
>>    * Project Kimchi
>>    *
>> - * Copyright IBM Corp, 2016
>> + * Copyright IBM Corp, 2016-2017
>>    *
>>    * Licensed under the Apache License, Version 2.0 (the "License");
>>    * you may not use this file except in compliance with the License.
>> @@ -51,6 +51,10 @@
>>                       <i class="fa fa-info-circle"></i> $_("Password 
>> of the user in the remote host")</p>
>>               </div>
>>               <div class="form-group">
>> +                <input id="enableRDMA" class="wok-checkbox" 
>> type="checkbox" value="" />
>> +                <label for="enableRDMA" id="labelEnableRDMA">$_("Use 
>> RDMA transport") </label>
>> +            </div>
>> +            <div class="form-group">
>>                   <input id="deleteVM" class="wok-checkbox" 
>> type="checkbox" value="" />
>>                   <label for="deleteVM" id="labelDeleteVM">$_("Delete 
>> this VM when the migration is completed") </label>
>>               </div>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>