Re: [ovirt-devel] Vdsm patches need review and merge

From: "Dan Kenigsberg" <danken(a)redhat.com&gt; To: "Francesco Romani" <fromani(a)redhat.com&gt; Cc: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com&gt;, "Gilad Chaplik(gchaplik(a)redhat.com)&quot; <gchaplik(a)redhat.com&gt;, "Doron Fediuck (dfediuck(a)redhat.com)&quot; <dfediuck(a)redhat.com&gt;, "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com&gt;, devel(a)ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang(a)hp.com&gt; Sent: Thursday, May 8, 2014 4:02:44 PM Subject: Re: Vdsm patches need review and merge On Thu, May 08, 2014 at 08:48:52AM -0400, Francesco Romani wrote: > > ----- Original Message ----- > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi(a)hp.com&gt; > > To: "Dan Kenigsberg (danken(a)redhat.com)&quot; <danken(a)redhat.com&gt;, "Francesco > > Romani" <fromani(a)redhat.com&gt; > > Cc: "Gilad Chaplik <gchaplik(a)redhat.com&gt; (gchaplik(a)redhat.com)&quot; > > <gchaplik(a)redhat.com&gt;, "Doron Fediuck > > (dfediuck(a)redhat.com)&quot; <dfediuck(a)redhat.com&gt;, "Chuan Liao (Jason Liao, > > HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com&gt;, > > devel(a)ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" > > <shangchun.liang(a)hp.com&gt; > > Sent: Thursday, May 8, 2014 2:33:14 PM > > Subject: RE: Vdsm patches need review and merge > > > > Hi Dan/Francesco, > > > > Could you help to review and merge these patches: > > http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since > > some > > comments in that patch need to modify caps module) > > http://gerrit.ovirt.org/#/c/26876/ > > http://gerrit.ovirt.org/#/c/27403/ > > > > I didn't modify some comments in 26876 since I think they are related > > with > > codes refactor and literal syntax. I will submit a separate patch to > > modify > > these kinds of comments of numa feature altogether later. Could you > > please > > now focus on the functionality since we need to merge these patches ASAP? > > http://gerrit.ovirt.org/#/c/27403 > I'm OK with it (gave +1) > > http://gerrit.ovirt.org/#/c/26876 > I don't have objections and I don't see blockers for the functionality. > I'm not 100% happy with the implementation, but the existing one is on par > with most of code, and if we're in hurry, I guess refinements can wait. > > http://gerrit.ovirt.org/#/c/27515 > good enough for the same reasons above (gave +1) Puritans would suggest to squash this into 26876, or fix the commit message - prior to 26876 nothing uses these private methods. But never mind, taken.