5:47 p.m.
Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen of hooks for different
needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for network related hooks.
In general we are planning to prepare framework for future support of bunch network
related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Note: In the first stage we can implement these hooks without any parameters, just to
provide an entry point
for simple hooks.
Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD
Bondings manipulations:
- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD
General purpose:
- before_persist_network
- after_persist_network
Now we just need to figure out the use cases.
Your input more than welcome...
[1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for NIC hotplug
[2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support
Regards,
Igor Lvovsky
5:53 p.m.
On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen of hooks for different
needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for network related hooks.
In general we are planning to prepare framework for future support of bunch network
related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Note: In the first stage we can implement these hooks without any parameters, just to
provide an entry point
for simple hooks.
Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD
Bondings manipulations:
Bond might be interesting because it may require switch configuration -
but so will VLAN changes, so perhaps triggers in VLAN changes are
worthwhile as well.
Y.
- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD
General purpose:
- before_persist_network
- after_persist_network
Now we just need to figure out the use cases.
Your input more than welcome...
[1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for NIC hotplug
[2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support
Regards,
Igor Lvovsky
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
6:29 p.m.
----- Original Message -----
From: "Yaniv Kaul" <ykaul(a)redhat.com>
To: "Igor Lvovsky" <ilvovsky(a)redhat.com>
Cc: "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org>,
"engine-devel" <engine-devel(a)ovirt.org>, "Dan Yasny"
<dyasny(a)redhat.com>
Sent: Wednesday, October 10, 2012 4:53:19 PM
Subject: Re: [Engine-devel] Network related hooks in vdsm
On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
> Hi everyone,
> As you know vdsm has hooks mechanism and we already support dozen
> of hooks for different needs.
> Now it's a network's time.
> We would like to get your comments regarding our proposition for
> network related hooks.
>
> In general we are planning to prepare framework for future support
> of bunch network related hooks.
> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
>
> Below you can find the additional hooks list that we propose:
>
> Note: In the first stage we can implement these hooks without any
> parameters, just to provide an entry point
> for simple hooks.
>
> Networks manipulation:
> - before_add_network(conf={}, customProperty={})
> - after_add_network(conf={}, customProperty={})
> - before_del_network(conf={}, customProperty={})
> - after_del_network(conf={}, customProperty={})
> - before_edit_network(conf={}, customProperty={})
> - after_edit_network(conf={}, customProperty={})
> - TBD
>
> Bondings manipulations:
Bond might be interesting because it may require switch configuration
-
but so will VLAN changes, so perhaps triggers in VLAN changes are
worthwhile as well.
You are right, but in our implementation VLAN changes are part of network manipulation.
So, it's already covered by list above
Y.
> - before_add_bond(conf={}, customProperty={})
> - after_add_bond(conf={}, customProperty={})
> - before_del_bond(conf={}, customProperty={})
> - after_del_bond(conf={}, customProperty={})
> - before_edit_bond(conf={}, customProperty={})
> - after_edit_bond(conf={}, customProperty={})
> - TBD
>
> General purpose:
> - before_persist_network
> - after_persist_network
>
>
> Now we just need to figure out the use cases.
>
> Your input more than welcome...
>
> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
> NIC hotplug
> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX
> support
>
>
> Regards,
> Igor Lvovsky
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
10:44 p.m.
----- Original Message -----
From: "Yaniv Kaul" <ykaul(a)redhat.com>
To: "Igor Lvovsky" <ilvovsky(a)redhat.com>
Cc: "Dan Yasny" <dyasny(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, "vdsm-devel"
<vdsm-devel(a)lists.fedorahosted.org>
Sent: Wednesday, October 10, 2012 10:53:19 AM
Subject: Re: [Engine-devel] Network related hooks in vdsm
On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
> Hi everyone,
> As you know vdsm has hooks mechanism and we already support dozen
> of hooks for different needs.
> Now it's a network's time.
> We would like to get your comments regarding our proposition for
> network related hooks.
>
> In general we are planning to prepare framework for future support
> of bunch network related hooks.
> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
>
> Below you can find the additional hooks list that we propose:
>
> Note: In the first stage we can implement these hooks without any
> parameters, just to provide an entry point
> for simple hooks.
>
> Networks manipulation:
> - before_add_network(conf={}, customProperty={})
> - after_add_network(conf={}, customProperty={})
> - before_del_network(conf={}, customProperty={})
> - after_del_network(conf={}, customProperty={})
> - before_edit_network(conf={}, customProperty={})
> - after_edit_network(conf={}, customProperty={})
> - TBD
>
> Bondings manipulations:
Bond might be interesting because it may require switch configuration
-
but so will VLAN changes, so perhaps triggers in VLAN changes are
worthwhile as well.
Y.
> - before_add_bond(conf={}, customProperty={})
> - after_add_bond(conf={}, customProperty={})
> - before_del_bond(conf={}, customProperty={})
> - after_del_bond(conf={}, customProperty={})
> - before_edit_bond(conf={}, customProperty={})
> - after_edit_bond(conf={}, customProperty={})
> - TBD
>
> General purpose:
> - before_persist_network
> - after_persist_network
What about some way of doing a push that's not tied to an event - if we want to
"push" something
>
>
> Now we just need to figure out the use cases.
>
> Your input more than welcome...
>
> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
> NIC hotplug
> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX
> support
>
>
> Regards,
> Igor Lvovsky
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
11:08 a.m.
On Wed, Oct 10, 2012 at 03:44:24PM -0400, Andrew Cathrow wrote:
----- Original Message -----
> From: "Yaniv Kaul" <ykaul(a)redhat.com>
> To: "Igor Lvovsky" <ilvovsky(a)redhat.com>
> Cc: "Dan Yasny" <dyasny(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, "vdsm-devel"
> <vdsm-devel(a)lists.fedorahosted.org>
> Sent: Wednesday, October 10, 2012 10:53:19 AM
> Subject: Re: [Engine-devel] Network related hooks in vdsm
>
> On 10/10/2012 04:47 PM, Igor Lvovsky wrote:
> > Hi everyone,
> > As you know vdsm has hooks mechanism and we already support dozen
> > of hooks for different needs.
> > Now it's a network's time.
> > We would like to get your comments regarding our proposition for
> > network related hooks.
> >
> > In general we are planning to prepare framework for future support
> > of bunch network related hooks.
> > Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
> >
> > Below you can find the additional hooks list that we propose:
> >
> > Note: In the first stage we can implement these hooks without any
> > parameters, just to provide an entry point
> > for simple hooks.
> >
> > Networks manipulation:
> > - before_add_network(conf={}, customProperty={})
> > - after_add_network(conf={}, customProperty={})
> > - before_del_network(conf={}, customProperty={})
> > - after_del_network(conf={}, customProperty={})
> > - before_edit_network(conf={}, customProperty={})
> > - after_edit_network(conf={}, customProperty={})
> > - TBD
> >
> > Bondings manipulations:
>
> Bond might be interesting because it may require switch configuration
> -
> but so will VLAN changes, so perhaps triggers in VLAN changes are
> worthwhile as well.
> Y.
>
> > - before_add_bond(conf={}, customProperty={})
> > - after_add_bond(conf={}, customProperty={})
> > - before_del_bond(conf={}, customProperty={})
> > - after_del_bond(conf={}, customProperty={})
> > - before_edit_bond(conf={}, customProperty={})
> > - after_edit_bond(conf={}, customProperty={})
> > - TBD
> >
> > General purpose:
> > - before_persist_network
> > - after_persist_network
What about some way of doing a push that's not tied to an event - if we want to
"push" something
Would you elaborate on that? I don't understand the English.
Are you looking for a hook that is not tied to a specific network,
rather a before_setupnetworks/after_setupnetworks ?
Dan.
6:03 p.m.
----- Original Message -----
From: "Igor Lvovsky" <ilvovsky(a)redhat.com>
To: "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org>,
"engine-devel" <engine-devel(a)ovirt.org>
Cc: "Dan Yasny" <dyasny(a)redhat.com>
Sent: Wednesday, October 10, 2012 4:47:28 PM
Subject: [Engine-devel] Network related hooks in vdsm
Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen of
hooks for different needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for
network related hooks.
In general we are planning to prepare framework for future support of
bunch network related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Note: In the first stage we can implement these hooks without any
parameters, just to provide an entry point
for simple hooks.
Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD
+ VM networking related points in addition to before/after vm start/stop
before_hotplug_nic(conf={}, customProperty={})
*after_hotplug_nic(conf={}, customProperty={})
before_hotunplug_nic(conf={}, customProperty={})
*after_hotunplug_nic(conf={}, customProperty={})
* Not sure about use case for those two
The above will require VM IDs and networks? Sorry that I did not look into the actual
implementation of the above naming is more of a guess work, but I think the meaning is
clear. There may be other VM networking related entry points I've missed.
Bondings manipulations:
- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD
General purpose:
- before_persist_network
- after_persist_network
Now we just need to figure out the use cases.
Your input more than welcome...
[1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
NIC hotplug
[2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support
Regards,
Igor Lvovsky
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
6:27 p.m.
----- Original Message -----
From: "Simon Grinberg" <simon(a)redhat.com>
To: "Igor Lvovsky" <ilvovsky(a)redhat.com>
Cc: "Dan Yasny" <dyasny(a)redhat.com>, "vdsm-devel"
<vdsm-devel(a)lists.fedorahosted.org>, "engine-devel"
<engine-devel(a)ovirt.org>
Sent: Wednesday, October 10, 2012 5:03:52 PM
Subject: Re: [Engine-devel] Network related hooks in vdsm
----- Original Message -----
> From: "Igor Lvovsky" <ilvovsky(a)redhat.com>
> To: "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org>,
> "engine-devel" <engine-devel(a)ovirt.org>
> Cc: "Dan Yasny" <dyasny(a)redhat.com>
> Sent: Wednesday, October 10, 2012 4:47:28 PM
> Subject: [Engine-devel] Network related hooks in vdsm
>
> Hi everyone,
> As you know vdsm has hooks mechanism and we already support dozen
> of
> hooks for different needs.
> Now it's a network's time.
> We would like to get your comments regarding our proposition for
> network related hooks.
>
> In general we are planning to prepare framework for future support
> of
> bunch network related hooks.
> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
>
> Below you can find the additional hooks list that we propose:
>
> Note: In the first stage we can implement these hooks without any
> parameters, just to provide an entry point
> for simple hooks.
>
> Networks manipulation:
> - before_add_network(conf={}, customProperty={})
> - after_add_network(conf={}, customProperty={})
> - before_del_network(conf={}, customProperty={})
> - after_del_network(conf={}, customProperty={})
> - before_edit_network(conf={}, customProperty={})
> - after_edit_network(conf={}, customProperty={})
> - TBD
+ VM networking related points in addition to before/after vm
start/stop
before_hotplug_nic(conf={}, customProperty={})
*after_hotplug_nic(conf={}, customProperty={})
before_hotunplug_nic(conf={}, customProperty={})
*after_hotunplug_nic(conf={}, customProperty={})
* Not sure about use case for those two
Yep, part of them already proposed by Itzik (look at [1])
The above will require VM IDs and networks? Sorry that I did not
look
into the actual implementation of the above naming is more of a
guess work, but I think the meaning is clear. There may be other VM
networking related entry points I've missed.
>
> Bondings manipulations:
> - before_add_bond(conf={}, customProperty={})
> - after_add_bond(conf={}, customProperty={})
> - before_del_bond(conf={}, customProperty={})
> - after_del_bond(conf={}, customProperty={})
> - before_edit_bond(conf={}, customProperty={})
> - after_edit_bond(conf={}, customProperty={})
> - TBD
>
> General purpose:
> - before_persist_network
> - after_persist_network
>
>
> Now we just need to figure out the use cases.
>
> Your input more than welcome...
>
> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
> NIC hotplug
> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX
> support
>
>
> Regards,
> Igor Lvovsky
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
6:35 p.m.
----- Original Message -----
From: "Igor Lvovsky" <ilvovsky(a)redhat.com>
To: "Simon Grinberg" <simon(a)redhat.com>
Cc: "Dan Yasny" <dyasny(a)redhat.com>, "engine-devel"
<engine-devel(a)ovirt.org>, "vdsm-devel"
<vdsm-devel(a)lists.fedorahosted.org>
Sent: Wednesday, October 10, 2012 5:27:13 PM
Subject: Re: [Engine-devel] Network related hooks in vdsm
----- Original Message -----
> From: "Simon Grinberg" <simon(a)redhat.com>
> To: "Igor Lvovsky" <ilvovsky(a)redhat.com>
> Cc: "Dan Yasny" <dyasny(a)redhat.com>, "vdsm-devel"
> <vdsm-devel(a)lists.fedorahosted.org>, "engine-devel"
> <engine-devel(a)ovirt.org>
> Sent: Wednesday, October 10, 2012 5:03:52 PM
> Subject: Re: [Engine-devel] Network related hooks in vdsm
>
>
>
> ----- Original Message -----
> > From: "Igor Lvovsky" <ilvovsky(a)redhat.com>
> > To: "vdsm-devel" <vdsm-devel(a)lists.fedorahosted.org>,
> > "engine-devel" <engine-devel(a)ovirt.org>
> > Cc: "Dan Yasny" <dyasny(a)redhat.com>
> > Sent: Wednesday, October 10, 2012 4:47:28 PM
> > Subject: [Engine-devel] Network related hooks in vdsm
> >
> > Hi everyone,
> > As you know vdsm has hooks mechanism and we already support dozen
> > of
> > hooks for different needs.
> > Now it's a network's time.
> > We would like to get your comments regarding our proposition for
> > network related hooks.
> >
> > In general we are planning to prepare framework for future
> > support
> > of
> > bunch network related hooks.
> > Some of them already proposed by Itzik Brown [1] and Dan Yasny
> > [2].
> >
> > Below you can find the additional hooks list that we propose:
> >
> > Note: In the first stage we can implement these hooks without any
> > parameters, just to provide an entry point
> > for simple hooks.
> >
> > Networks manipulation:
> > - before_add_network(conf={}, customProperty={})
> > - after_add_network(conf={}, customProperty={})
> > - before_del_network(conf={}, customProperty={})
> > - after_del_network(conf={}, customProperty={})
> > - before_edit_network(conf={}, customProperty={})
> > - after_edit_network(conf={}, customProperty={})
> > - TBD
>
> + VM networking related points in addition to before/after vm
> start/stop
> before_hotplug_nic(conf={}, customProperty={})
> *after_hotplug_nic(conf={}, customProperty={})
> before_hotunplug_nic(conf={}, customProperty={})
> *after_hotunplug_nic(conf={}, customProperty={})
>
> * Not sure about use case for those two
>
Yep, part of them already proposed by Itzik (look at [1])
This is what happen when you miss out the end of the email :)
But if I'm reading the comment correctly it indeed doesn't implement two of the 4
above. My '*' was in the wrong location, indeed the two suggested in the patch are
the two I can find a use case for, while the other two I'm not sure of but I think
should be implemented for completeness.
> The above will require VM IDs and networks? Sorry that I did not
> look
> into the actual implementation of the above naming is more of a
> guess work, but I think the meaning is clear. There may be other VM
> networking related entry points I've missed.
>
> >
> > Bondings manipulations:
> > - before_add_bond(conf={}, customProperty={})
> > - after_add_bond(conf={}, customProperty={})
> > - before_del_bond(conf={}, customProperty={})
> > - after_del_bond(conf={}, customProperty={})
> > - before_edit_bond(conf={}, customProperty={})
> > - after_edit_bond(conf={}, customProperty={})
> > - TBD
> >
> > General purpose:
> > - before_persist_network
> > - after_persist_network
> >
> >
> > Now we just need to figure out the use cases.
> >
> > Your input more than welcome...
> >
> > [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support
> > for
> > NIC hotplug
> > [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX
> > support
> >
> >
> > Regards,
> > Igor Lvovsky
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel(a)ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
9:20 a.m.
----- Original Message -----
Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen of
hooks for different needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for
network related hooks.
In general we are planning to prepare framework for future support of
bunch network related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Note: In the first stage we can implement these hooks without any
parameters, just to provide an entry point
for simple hooks.
Will the admin be able to supply a sort of free-text "custom properties" field
which will be passed to the hook?
If so, at what level (in the engine entities) should it be defined?
Host NIC seems to make the most sense as this is where you actually pass this info, but
perhaps it should be defined on a higher level?
Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD
Bondings manipulations:
- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD
General purpose:
- before_persist_network
- after_persist_network
Now we just need to figure out the use cases.
Your input more than welcome...
[1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
NIC hotplug
[2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support
Regards,
Igor Lvovsky
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
9:40 a.m.
On 10/10/12 16:47, Igor Lvovsky wrote:
Hi everyone,
As you know vdsm has hooks mechanism and we already support dozen of hooks for different
needs.
Now it's a network's time.
We would like to get your comments regarding our proposition for network related hooks.
In general we are planning to prepare framework for future support of bunch network
related hooks.
Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Many of the API calls bellow are deprecated. Why do we want to add hooks
before/after to deprecated APIs?
Note: In the first stage we can implement these hooks without any
parameters, just to provide an entry point
for simple hooks.
Networks manipulation:
- before_add_network(conf={}, customProperty={})
- after_add_network(conf={}, customProperty={})
- before_del_network(conf={}, customProperty={})
- after_del_network(conf={}, customProperty={})
- before_edit_network(conf={}, customProperty={})
- after_edit_network(conf={}, customProperty={})
- TBD
Bondings manipulations:
- before_add_bond(conf={}, customProperty={})
- after_add_bond(conf={}, customProperty={})
- before_del_bond(conf={}, customProperty={})
- after_del_bond(conf={}, customProperty={})
- before_edit_bond(conf={}, customProperty={})
- after_edit_bond(conf={}, customProperty={})
- TBD
General purpose:
- before_persist_network
- after_persist_network
Now we just need to figure out the use cases.
Your input more than welcome...
[1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for NIC hotplug
[2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support
Regards,
Igor Lvovsky
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
9:52 a.m.
----- Original Message -----
On 10/10/12 16:47, Igor Lvovsky wrote:
> Hi everyone,
> As you know vdsm has hooks mechanism and we already support dozen
> of hooks for different needs.
> Now it's a network's time.
> We would like to get your comments regarding our proposition for
> network related hooks.
>
> In general we are planning to prepare framework for future support
> of bunch network related hooks.
> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
>
> Below you can find the additional hooks list that we propose:
>
Many of the API calls bellow are deprecated. Why do we want to add
hooks
before/after to deprecated APIs?
They are actually still very much in use with the REST API.
Perhaps we should address just the logical entry points instead of specific commands.
A command such as setup networks can trigger multiple logical events in which hooks can be
planted (same goes for edit network in a smaller scale).
> Note: In the first stage we can implement these hooks without any
> parameters, just to provide an entry point
> for simple hooks.
>
> Networks manipulation:
> - before_add_network(conf={}, customProperty={})
> - after_add_network(conf={}, customProperty={})
> - before_del_network(conf={}, customProperty={})
> - after_del_network(conf={}, customProperty={})
> - before_edit_network(conf={}, customProperty={})
> - after_edit_network(conf={}, customProperty={})
> - TBD
>
> Bondings manipulations:
> - before_add_bond(conf={}, customProperty={})
> - after_add_bond(conf={}, customProperty={})
> - before_del_bond(conf={}, customProperty={})
> - after_del_bond(conf={}, customProperty={})
> - before_edit_bond(conf={}, customProperty={})
> - after_edit_bond(conf={}, customProperty={})
> - TBD
>
> General purpose:
> - before_persist_network
> - after_persist_network
>
>
> Now we just need to figure out the use cases.
>
> Your input more than welcome...
>
> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
> NIC hotplug
> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX
> support
>
>
> Regards,
> Igor Lvovsky
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
10:31 a.m.
On 16/10/12 08:52, Mike Kolesnik wrote:
----- Original Message -----
> On 10/10/12 16:47, Igor Lvovsky wrote:
>> Hi everyone,
>> As you know vdsm has hooks mechanism and we already support dozen
>> of hooks for different needs.
>> Now it's a network's time.
>> We would like to get your comments regarding our proposition for
>> network related hooks.
>>
>> In general we are planning to prepare framework for future support
>> of bunch network related hooks.
>> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
>>
>> Below you can find the additional hooks list that we propose:
>>
>
> Many of the API calls bellow are deprecated. Why do we want to add
> hooks
> before/after to deprecated APIs?
They are actually still very much in use with the REST API.
Deprecate does not mean "not in use" but "not using it going
forward".
Today if a user is using 3.1 cluster/DC in the UI or the setupNetwork
API (which is the recommended way to configure your network in 3.1 and
in future versions) the hooks for add/edit-Network won't get activated
and that is confusing to the users (and the developers).
Perhaps we should address just the logical entry points instead of
specific commands.
A command such as setup networks can trigger multiple logical events in which hooks can
be planted (same goes for edit network in a smaller scale).
What you are suggesting above is to deviate from the current hook
mechanism we have in VDSM and add some logic to where/when we activate
hooks.
That's an interesting suggestion, I suggest to write a wiki page and
start thinking of the implementation implications of it.
Since I like the idea I'll work with you on the wiki and we'll see if we
can get something more useful to the users and send a formal proposal.
Livnat
>
>> Note: In the first stage we can implement these hooks without any
>> parameters, just to provide an entry point
>> for simple hooks.
>>
>> Networks manipulation:
>> - before_add_network(conf={}, customProperty={})
>> - after_add_network(conf={}, customProperty={})
>> - before_del_network(conf={}, customProperty={})
>> - after_del_network(conf={}, customProperty={})
>> - before_edit_network(conf={}, customProperty={})
>> - after_edit_network(conf={}, customProperty={})
>> - TBD
>>
>> Bondings manipulations:
>> - before_add_bond(conf={}, customProperty={})
>> - after_add_bond(conf={}, customProperty={})
>> - before_del_bond(conf={}, customProperty={})
>> - after_del_bond(conf={}, customProperty={})
>> - before_edit_bond(conf={}, customProperty={})
>> - after_edit_bond(conf={}, customProperty={})
>> - TBD
>>
>> General purpose:
>> - before_persist_network
>> - after_persist_network
>>
>>
>> Now we just need to figure out the use cases.
>>
>> Your input more than welcome...
>>
>> [1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for
>> NIC hotplug
>> [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX
>> support
>>
>>
>> Regards,
>> Igor Lvovsky
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
3:18 a.m.
New subject: [Engine-devel] [vdsm] Network related hooks in vdsm
On 10/16/2012 09:31 AM, Livnat Peer wrote:
On 16/10/12 08:52, Mike Kolesnik wrote:
> ----- Original Message -----
>> On 10/10/12 16:47, Igor Lvovsky wrote:
>>> Hi everyone,
>>> As you know vdsm has hooks mechanism and we already support dozen
>>> of hooks for different needs.
>>> Now it's a network's time.
>>> We would like to get your comments regarding our proposition for
>>> network related hooks.
>>>
>>> In general we are planning to prepare framework for future support
>>> of bunch network related hooks.
>>> Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
>>>
>>> Below you can find the additional hooks list that we propose:
>>>
>>
>> Many of the API calls bellow are deprecated. Why do we want to add
>> hooks
>> before/after to deprecated APIs?
>
> They are actually still very much in use with the REST API.
>
Deprecate does not mean "not in use" but "not using it going
forward".
Today if a user is using 3.1 cluster/DC in the UI or the setupNetwork
API (which is the recommended way to configure your network in 3.1 and
in future versions) the hooks for add/edit-Network won't get activated
and that is confusing to the users (and the developers).
> Perhaps we should address just the logical entry points instead of specific
commands.
> A command such as setup networks can trigger multiple logical events in which hooks
can be planted (same goes for edit network in a smaller scale).
>
What you are suggesting above is to deviate from the current hook
mechanism we have in VDSM and add some logic to where/when we activate
hooks.
That's an interesting suggestion, I suggest to write a wiki page and
start thinking of the implementation implications of it.
Since I like the idea I'll work with you on the wiki and we'll see if we
can get something more useful to the users and send a formal proposal.
question is there is any high demand/priority for network hooks other
than hotplug nic, and do we have a clear vision of a stable api for them.
one thing to consider is allowing to define custom properties at logical
network and virtual nic level though.
4414
days inactive
4422
days old
12 comments
8 participants
participants (8)
-
Andrew Cathrow -
Dan Kenigsberg -
Igor Lvovsky -
Itamar Heim -
Livnat Peer -
Mike Kolesnik -
Simon Grinberg -
Yaniv Kaul