----- Original Message -----
From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei.shi@hp.com> To: "Dan Kenigsberg (danken@redhat.com)" <danken@redhat.com>, "Francesco Romani" <fromani@redhat.com> Cc: "Gilad Chaplik <gchaplik@redhat.com> (gchaplik@redhat.com)" <gchaplik@redhat.com>, "Doron Fediuck (dfediuck@redhat.com)" <dfediuck@redhat.com>, "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao@hp.com>, devel@ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" <shangchun.liang@hp.com> Sent: Thursday, May 8, 2014 2:33:14 PM Subject: RE: Vdsm patches need review and merge
Hi Dan/Francesco,
Could you help to review and merge these patches: http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since some comments in that patch need to modify caps module) http://gerrit.ovirt.org/#/c/26876/ http://gerrit.ovirt.org/#/c/27403/
I didn't modify some comments in 26876 since I think they are related with codes refactor and literal syntax. I will submit a separate patch to modify these kinds of comments of numa feature altogether later. Could you please now focus on the functionality since we need to merge these patches ASAP?
http://gerrit.ovirt.org/#/c/27403 I'm OK with it (gave +1) http://gerrit.ovirt.org/#/c/26876 I don't have objections and I don't see blockers for the functionality. I'm not 100% happy with the implementation, but the existing one is on par with most of code, and if we're in hurry, I guess refinements can wait. http://gerrit.ovirt.org/#/c/27515 good enough for the same reasons above (gave +1) Bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani