From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)"
<xiao-lei.shi(a)hp.com>
To: "Dan Kenigsberg (danken(a)redhat.com)" <danken(a)redhat.com>,
"Francesco Romani" <fromani(a)redhat.com>
Cc: "Gilad Chaplik <gchaplik(a)redhat.com> (gchaplik(a)redhat.com)"
<gchaplik(a)redhat.com>, "Doron Fediuck
(dfediuck(a)redhat.com)" <dfediuck(a)redhat.com>, "Chuan Liao (Jason Liao,
HPservers-Core-OE-PSC)" <chuan.liao(a)hp.com>,
devel(a)ovirt.org, "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)"
<shangchun.liang(a)hp.com>
Sent: Thursday, May 8, 2014 2:33:14 PM
Subject: RE: Vdsm patches need review and merge
Hi Dan/Francesco,
Could you help to review and merge these patches:
http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since some
comments in that patch need to modify caps module)
http://gerrit.ovirt.org/#/c/26876/
http://gerrit.ovirt.org/#/c/27403/
I didn't modify some comments in 26876 since I think they are related with
codes refactor and literal syntax. I will submit a separate patch to modify
these kinds of comments of numa feature altogether later. Could you please
now focus on the functionality since we need to merge these patches ASAP?
I don't have objections and I don't see blockers for the functionality.
I'm not 100% happy with the implementation, but the existing one is on par
with most of code, and if we're in hurry, I guess refinements can wait.
good enough for the same reasons above (gave +1)
Bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani