[ovirt-devel] [VDSM] Do not use commands.execCmd(cmd, sync=False) or AsyncProcessOperation

I just found that this patch was merged last month: https://gerrit.ovirt.org/c/94269/ Adding another use of commands.execCmd(cmd, sync=False) and AsyncProcessOperation. These APIs are deprecated and will be removed soon, please do merge any code using them. Also running commands anachronistically with a timeout is a bad idea in general. If the command is stuck on storage, we will created huge amount of commands. We have the same bad pattern in storage (iscsi/fcp rescan), it should be replaced by running command synchronically (sync=False) in a dedicated thread, and never running more then one command if the command get stuck. Marcin is working on the new improved infrastructure for running commands, based on https://gerrit.ovirt.org/c/83923. Nir