Re: [ovirt-devel] how does findbugs work?

On 21 Dec 2016, at 12:23, Eyal Edri <eedri(a)redhat.com&gt; wrote: You can see from the output the maven plugin is running [1], Have you checked the filters that are ignoring 'false positives'? maybe those needs to be updated? The are in the 'exclude-filters.xml' files under each project and maintained by the ovirt-engine maintainers. AFAICT no, it’s not excluded, but checking whole ovirt-engine on coverity site I can’t seem to find the whole file. I dunno, I’m not much of an expert, but I do not see any exclude anywhere and there are bunch of other files in the same dir… anyone any idea?

[1] 08:13:21 [FINDBUGS] Collecting findbugs analysis files... 08:13:23 [FINDBUGS] Finding all files that match the pattern **/findbugsXml.xml 08:13:23 [FINDBUGS] Parsing 34 files in /home/jenkins/workspace/ovirt- engine_master_find-bugs_created 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/extensions-tool/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/aaa/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/auth-plugin/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/bll/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/branding/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/builtin-extensions/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/common/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/compat/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/dal/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/docs/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/enginesso/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/extensions-api-root/extensions-api/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/extensions-manager/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/logger/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/restapi/interface/common/jaxrs/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/restapi/interface/definition/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/restapi/jaxrs/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/restapi/types/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/scheduler/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/searchbackend/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/services/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/utils/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/uutils/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/vdsbroker/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/ manager/modules/welcome/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/backend/manager/tools/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/build- tools-root/ovirt-checkstyle-extension/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/frontend/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/gwt-common/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/gwt-extension/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/uicommonweb/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/uicompat/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/userportal-gwtp/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Successfully parsed file /home/jenkins/workspace/ovirt- engine_master_find-bugs_created/ovirt-engine/frontend/ webadmin/modules/webadmin/target/findbugsXml.xml with 0 unique warnings and 0 duplicates. 08:13:23 [FINDBUGS] Computing warning deltas based on reference build #11731 08:13:23 [FINDBUGS] Ignore new warnings since this is the first valid build 08:13:23 [FINDBUGS] Plug-in Result: Success - no threshold has been exceeded On Wed, Dec 21, 2016 at 12:42 PM, Michal Skrivanek < michal.skrivanek(a)redhat.com&gt; wrote: > Hi, > I was trying to see why the recent NPE[1] was not found by findbugs. > Typically identifying potential NPE is the most easy thing…but it was not > reported. > So I triggered the build again on the wrong patch [2] and it doesn’t show > anything useful[3] > Does it work at all? > There seem to be no artifacts to review that > > Thanks, > michal > > [1] https://gerrit.ovirt.org/#/c/68731 > [2] https://gerrit.ovirt.org/#/c/68400/5 > [3] http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_c > reated/11732/ > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > > > -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)