10:28 p.m.
On Wed, Sep 14, 2016 at 10:43 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman
<igoihman(a)redhat.com> wrote:
> I think that what's missing in build-artifacts.sh is the following commands
> that exist in check-patch.sh:
>
> easy_install pip
> pip install -U nose==1.3.7
We cannot do this in brew/koji, you can use only packages from the distribution
when running make rpm.
The best way to avoid such issues is to remove the "make tests"
from the %check section in the spec.
This allows using latest and greatest development tools which are not available
in brew or koji.
Here is a quick patch, please review:
https://gerrit.ovirt.org/63966
> This should install the right version for nose (that doesn't
exist in rhel
> yum repos)
>
> On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri <eedri(a)redhat.com> wrote:
>>
>> Its actually a good question to know if standard CI supports versions of
>> RPMs.
>> Barak - do you know if we can specify in build-artifacts.packages file a
>> version requirement?
>>
>> for e.g python-nose >= 1.3.7
>>
>> On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer <nsoffer(a)redhat.com> wrote:
>>>
>>> The build-artifacts job is failing on master now with this error:
>>>
>>> 19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
>>> 19:09:23 make[1]: *** [tests] Error 1
>>> 19:09:23 make[1]: Leaving directory
>>>
>>>
`/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
>>> 19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>>> 19:09:23
>>> 19:09:23
>>> 19:09:23 RPM build errors:
>>> 19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>>>
>>> Looks like this patch is the cause:
>>>
>>> commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
>>> Author: Edward Haas <edwardh(a)redhat.com>
>>> Date: Sun Sep 11 14:10:01 2016 +0300
>>>
>>> build tests: Require NOSE 1.3.7 and up for running tests
>>>
>>> On RHEL7/Centos7 the provided NOSE version is 1.3.0.
>>> CI runs the tests with 1.3.7.
>>>
>>> To be consistent and avoid different behaviours, assure that the
>>> tests
>>> are running with a minimum nose version of 1.3.7.
>>>
>>> Specifically, between 1.3.0 and 1.3.7 a bug has been resolved
>>> regarding
>>> test labeling and its support with test class inheritance.
>>>
>>> Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
>>> Signed-off-by: Edward Haas <edwardh(a)redhat.com>
>>> Reviewed-on: https://gerrit.ovirt.org/63638
>>> Continuous-Integration: Jenkins CI
>>> Reviewed-by: Petr Horáček <phoracek(a)redhat.com>
>>> Reviewed-by: Irit Goihman <igoihman(a)redhat.com>
>>> Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
>>> Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
>>>
>>> I did not check the details, but it seems we need to revert this patch.
>>>
>>> Please check and fix.
>>>
>>> Cheers,
>>> Nir
>>> _______________________________________________
>>> Infra mailing list
>>> Infra(a)ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>
>>>
>>
>>
>>
>> --
>> Eyal Edri
>> Associate Manager
>> RHV DevOps
>> EMEA ENG Virtualization R&D
>> Red Hat Israel
>>
>> phone: +972-9-7692018
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>
>> _______________________________________________
>> Devel mailing list
>> Devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
>
> --
> Irit Goihman
> Software Engineer
> Red Hat Israel Ltd.