Re: [Devel] Network custom properties

From: "Dan Kenigsberg" <danken(a)redhat.com&gt; To: "Lior Vernia" <lvernia(a)redhat.com&gt;, asegurap(a)redhat.com Cc: devel(a)ovirt.org, &quot;Users(a)ovirt.org List" <Users(a)ovirt.org&gt; Sent: Monday, April 7, 2014 12:21:03 AM Subject: Re: Network custom properties On Sun, Apr 06, 2014 at 11:33:29AM +0300, Lior Vernia wrote: > Hello all, > > Introducing the oVirt 3.5 feature of network custom properties: > http://www.ovirt.org/Features/Network_Custom_Properties > > Essentially, this feature aims to solve two RFEs, that request the > ability to set bridge and ethtool options on host interfaces from the > GUI/REST: > https://bugzilla.redhat.com/show_bug.cgi?id=1080984 > https://bugzilla.redhat.com/show_bug.cgi?id=1080987 > > It will do so by adding custom properties (key:value pairs) to networks > assigned to host interfaces, which can in turn be acted upon via hooks > when e.g. a Setup Networks command is triggered. > > Two predefined keys will include bridge_opts and ethtool_opts, but any > arbitrary custom property could be supplied as well. > > Please take a look at the detailed feature page and let me know if you > have any comments. Thanks for taking this feature! I think that it's very important to open up our network configuration to all sorts of things that users want and we have not even thought about. I did not read all the page, but I'm worried about http://www.ovirt.org/Features/Network_Custom_Properties#Vdsm The network-specific custom properties should be specific to a network, not to a setupNetwork command. They cannot be part of @SetupNetworkOptions, as two different network being set up by a single command may have different custom properties. The following example dictionary adds to the confusion with what seems to be a typo (bootproto is certainly not an option of 'bonding').

Dan.