Re: [Engine-devel] Inconsistent model->entity mapping in VmSnapshotListModel
----- Original Message -----
From: "Martin Betak" <mbetak(a)redhat.com>
To: "engine-devel" <engine-devel(a)ovirt.org>
Sent: Wednesday, January 22, 2014 2:14:40 PM
Subject: [Engine-devel] Inconsistent model->entity mapping in VmSnapshotListModel
Hi all,
during some of my frontend patches I noticed that the properties
- singleQxlPci
- allowConsoleReconnect
- runAndPause
are not mapped from UnitVmModel to VM business entity in
VmSnapshotListModel#onCloneVm method
while being mapped in all other fronted VM-related *ListModels
(UserPortalListModel, VmListModel, TemplateListModel)
and also that the 'comment' property is not being mapped in
UserPortalListModel#postVmNameUniqueCheck method.
Since I know that copy & pasting the appropriate setter to 6 different places
when adding new VM property
can be tedious and very error prone I would like to ask the frontend
maintainers if the above is desired behavior
or just bug caused by omission.
I guess onCloneVm/postVmNameUniqueCheck were simply missed while adding
these properties. So yeah, if these properties can indeed be modified
from the relevant dialog, then it seems like a bug.
@Tomas - did I miss something? is there any reason not to map them?
Best regards,
Martin
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel