From: "Ricky Hopper" <Ricky.Hopper(a)netapp.com>
To: "Dan Yasny" <dyasny(a)redhat.com>, "Andrew Cathrow"
Cc: engine-devel(a)ovirt.org, "Itamar Heim" <iheim(a)redhat.com>, "Ricky
Sent: Wednesday, 1 August, 2012 4:34:53 PM
Subject: Re: [Engine-devel] Domain rescan action question
On 8/1/12 5:59 AM, "Dan Yasny" <dyasny(a)redhat.com> wrote:
>----- Original Message -----
>> From: "Andrew Cathrow" <acathrow(a)redhat.com>
>> To: "Itamar Heim" <iheim(a)redhat.com>, "Dan Yasny"
>>"Ricky Hopper" <Ricky.Hopper(a)netapp.com>
>> Cc: engine-devel(a)ovirt.org
>> Sent: Wednesday, 1 August, 2012 12:24:42 AM
>> Subject: Re: [Engine-devel] Domain rescan action question
>> ----- Original Message -----
>> > From: "Itamar Heim" <iheim(a)redhat.com>
>> > To: "Ricky Hopper" <Ricky.Hopper(a)netapp.com>
>> > Cc: engine-devel(a)ovirt.org
>> > Sent: Tuesday, July 31, 2012 4:44:34 PM
>> > Subject: Re: [Engine-devel] Domain rescan action question
>> > On 07/31/2012 11:30 PM, Hopper, Ricky wrote:
>> > > Hey all,
>> > >
>> > > As I'm making progress with the domain rescan functionality,
>> > > I've
>> > > realized that I'm unsure what to do with any disks that are
>> > > detected on
>> > > the domain. Should I add them back into the database to be
>> > > listed
>> > > as
>> > > floating disks, or should I just return a list of disk images
>> > > to
>> > > be
>> > > attached to whatever the caller of the query needs?
>> > >
>> > > - Ricky
>> > i'm not sure they should be added automatically.
>> > I think a dialog showing orphan disks/images on the storage
>> > domain
>> > for user to choose which to import as 'floating' disks would be
>> > better
>> > than auto importing them.
>> > there is also the reverse of flagging existing disks as
>> > 'missing'
>> > in
>> > storage?
>> Perhaps we should start a feature page to discuss and better scope
>> There is a feature page that we could expand, it doesn't discuss
>> notion of importing those disks which is certainly something we
>> to address.
>The original idea was to scan the storage domains and compare the
>lists to the database, thus getting a list of images no longer
>and scrubbing the storage. This will actually be addressed properly
>the future (Ayal can elaborate on that) but for now this is needed
>least for that use case.
>As I understand, the conversation here is about trying to take an
>populated SD (from another setup I suppose), scanning it and putting
As I understood it, the purpose of this functionality wasn't to find
images which should be removed from storage, but to find images on
domain that oVirt was unaware of and importing them for use (for
if a disk was created outside of oVirt on the domain). If one of the
cases for this feature is also the orphaned images mentioned on the
feature page, that may expand the functionality into a separate
scrub and storage import, both of which would call the rescan
rescan would not actually add to the database, but instead return a
of "orphaned" disk images).
Another solution would be to import all disk images into the database
either way, and let the user delete any orphaned images from the GUI.
I think are nice to have, but the problem with the scanning is that if we're not
scanning a master domain or an export domain, all we will see is a bunch of images with no
context or even hints as to where they belong. The data that makes it all usable is in the
engine database and in the ovf files on the master domain.
This is why I stopped at the orphaned images part of the feature - because there it's
feasible, I would rely on the engine database for image ID comparisons.
If we present a user with a list of nameless disks, I doubt it will be of any use.
>> >  or a subtab on the storage domain.
>> > _______________________________________________
>> > Engine-devel mailing list
>> > Engine-devel(a)ovirt.org
>> > http://lists.ovirt.org/mailman/listinfo/engine-devel
>Red Hat Israel
>+972 9769 2280