Re: [ovirt-devel] [oVirt 4.2 Localization Question #4] @type LUNs

... yeah should be a $ fix: https://gerrit.ovirt.org/83216 (@Idan, can you verify?) git blame ./frontend/webadmin/modules/frontend/src/main/resources/ org/ovirt/engine/ui/frontend/AppErrors.properties |grep -C 5 VAR__TYPE__LUNS ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1177) VAR__TYPE__CLUSTER_POLICY=$type Scheduling Policy ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1178) VAR__TYPE__COMPUTER_ACCOUNT=$type Computer Account ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1179) VAR__TYPE__CPU_PROFILE=$type CPU Profile ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1180) VAR__TYPE__DESKTOP_POOL=$type VM-Pool ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1181) VAR__TYPE__DISK=$type Virtual Disk d99144f0882 (Idan Shaby 2017-07-03 11:17:50 +0300 1182) VAR__TYPE__LUNS=@type LUNs ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1183) VAR__TYPE__DISK_PROFILE=$type Disk Profile ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1184) VAR__TYPE__DISK__SNAPSHOT=$type Disk Snapshot 6d4008eddb3 (Jakub Niedermertl 2017-06-12 02:06:45 +0200 1185) VAR__TYPE__EXTERNAL_EVENT=$type External Event 6d4008eddb3 (Jakub Niedermertl 2017-06-12 02:06:45 +0200 1186) VAR__TYPE__EXTERNAL_JOB=$type External Job 6d4008eddb3 (Jakub Niedermertl 2017-06-12 02:06:45 +0200 1187) VAR__TYPE__EXTERNAL_STEP=$type External Step On Thu, Oct 26, 2017 at 6:02 AM, Greg Sheremeta <gshereme(a)redhat.com&gt; wrote: > I think Yuko meant: it should be a $ instead of @. > > Greg > > On Oct 26, 2017 2:28 AM, "Idan Shaby" <ishaby(a)redhat.com&gt; wrote: > >> Hi Yuko, >> >> I am not sure where exactly you meant that the typo is. >> - "LUNs" (in "@type LUNs") seems ok since LUN is an acronym and the "s" >> is for the plural. >> - "LUNS" (in "VAR__TYPE__LUNS") seems ok since variable names in >> AppErrors should be in capital letters. >> >> If I misunderstood please say so. >> >> >> Regards, >> Idan >> >> On Thu, Oct 26, 2017 at 3:18 AM, Yuko Katabami <ykatabam(a)redhat.com&gt; >> wrote: >> >>> Hello again. >>> Here is my next question. >>> >>> ​*File: *AppErrors >>> >>> *Resource ID: *VAR__TYPE__LUNS >>> ​​ >>> *String: *@type LUNs >>> *Question:* ​Is this a typo for "$type LUNs"? >>> >>> Yuko >>> >>> _______________________________________________ >>> Devel mailing list >>> Devel(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/devel >>> >> >> >> _______________________________________________ >> Devel mailing list >> Devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel >> >