----- Original Message -----
From: "Mike Kolesnik" <mkolesni@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "Itamar Heim" <iheim@redhat.com>, "engine-devel" <engine-devel@ovirt.org>, vdsm-devel@lists.fedorahosted.org Sent: Tuesday, January 28, 2014 9:05:21 AM Subject: Re: [Engine-devel] Gerrit NEW Change Screen
----- Original Message -----
----- Original Message -----
From: "Roy Golan" <rgolan@redhat.com> To: "Itamar Heim" <iheim@redhat.com>, vdsm-devel@lists.fedorahosted.org, "engine-devel" <engine-devel@ovirt.org> Sent: Sunday, January 26, 2014 9:12:38 AM Subject: Re: [Engine-devel] Gerrit NEW Change Screen
On 01/16/2014 12:08 AM, Itamar Heim wrote:
with gerrit 2.8, there is a new change screen. its not enabled by default (yet), please use and see what you think.
to enable, go to settings (click the top-right arrow next to your name, and choose settings). select preferences and set "Change View:" to "New Screen".
I had found that the new window truncates the code See for example line 115 in http://gerrit.ovirt.org/#/c/23428/2/backend/manager/modules/bll/src/main/jav... Switching to the old view will show all the line while in the new one it is truncated
It's just enforcing a certain line length (which this code obviously violates) ;)
I found that if you change the zoom on the page you'll get a scrollbar at the bottom so the line can be fully viewed..
Thanks for the workaround , it is still a bug not showing the full line...
Thanks, Itamar _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
+1 needs some time to get used to the new layout but overall its way better to have the patch dependency ("Related") and better without the cluttered patch-sets view. reminds me of gitk somewhat...
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel