On Thu, Mar 26, 2020 at 12:13 PM Tal Nisan <tnisan@redhat.com> wrote:

On Wed, Mar 25, 2020 at 6:42 PM Martin Perina <mperina@redhat.com> wrote:

...

Steven,

could you please a fix for the issue asap which we can used instead of revert?

Sorry but a basic functionality is broken for nearly two days, I've reverted, now a solution can be worked on with less rush.

Could you advise where this error is coming from: ERROR: null value in column "bios_type" violates not-null constraint Michal Skrivanek would like to remove the function from the AddClusterCommand altogether and leave it null until the first Host is up on a cluster. The patch is meant to fix the Bios Type default which is currently incorrect. With Best Regards. Steven.

...

Thanks, Martin

On Wed, Mar 25, 2020 at 4:48 PM Piotr Kliczewski <pkliczew@redhat.com> wrote:

...

Hi,

I posted revert [0] of commit [1] due to the issue with AddClusterCommand which fails for Adding new Kubevirt provider with:

ERROR: null value in column "bios_type" violates not-null constraint

I am happy to see different solution than revet but at the moment add cluster is not working.

Thanks, Piotr

[0] https://gerrit.ovirt.org/#/c/107928/ [1] 6b1d1e3099879d6991401dd545338f7a856fc426 _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/AMYRVJEWSNDJWW...

-- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o. _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RZWNFPZTWMPTIX...

On Thu, Mar 26, 2020 at 12:26 PM Shmuel Melamud <smelamud@redhat.com> wrote:

Hi!

On Thu, Mar 26, 2020 at 12:24 PM Steven Rosenberg <srosenbe@redhat.com> wrote:

...

Michal Skrivanek would like to remove the function from the AddClusterCommand altogether and leave it null until the first Host is up on a cluster.

But cluster's biosType is needed for creating and configuring VMs that have CLUSTER_DEFAULT biosType. And VMs may be added to a cluster that has no hosts.

Here is where we call AddCluster [0] and this code worked before mentioned patch. [0] https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/bl...

Shmuel