Re: [ovirt-devel] [vdsm] pep8 issue
On Tue, May 13, 2014 at 05:22:15PM -0300, Amador Pahim wrote:
Building vdsm/master in F20, I've got:
./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator
In vdsm/virt/migration.py:
218 e.err = (libvirt.VIR_ERR_OPERATION_ABORTED, # error code$ 219 libvirt.VIR_FROM_QEMU, # error domain$ 220 'operation aborted', # error message$ 221 libvirt.VIR_ERR_WARNING, # error level$ 222 '', '', '', # str1, str2, str3,$ 223 -1, -1) # int1, int2$ 224 raise e$
pep8 is not accepting negative integer. Instead, it is handling the minus sign as an operator. Quick workaround is change -1 to int(-1). Is this a known?
Now it is ;-)
I'm using python-pep8-1.5.4-1.fc20.noarch
It seems like a bug in pep8 tool, and I see that it does not reproduce with v1.5.6 thereof. I'm adding Matthias who may agree to backport the fix to Fedora 20 (or upgrade completely to 1.5.6)
On Tue, May 13, 2014 at 5:43 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Tue, May 13, 2014 at 05:22:15PM -0300, Amador Pahim wrote:
Building vdsm/master in F20, I've got:
./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator
In vdsm/virt/migration.py:
218 e.err = (libvirt.VIR_ERR_OPERATION_ABORTED, # error code$ 219 libvirt.VIR_FROM_QEMU, # error domain$ 220 'operation aborted', # error message$ 221 libvirt.VIR_ERR_WARNING, # error level$ 222 '', '', '', # str1, str2, str3,$ 223 -1, -1) # int1, int2$ 224 raise e$
pep8 is not accepting negative integer. Instead, it is handling the minus sign as an operator. Quick workaround is change -1 to int(-1). Is this a known?
Now it is ;-)
I'm using python-pep8-1.5.4-1.fc20.noarch
It seems like a bug in pep8 tool, and I see that it does not reproduce with v1.5.6 thereof.
I'm adding Matthias who may agree to backport the fix to Fedora 20 (or upgrade completely to 1.5.6)
Great, thank you. -- Pahim
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, May 13, 2014 at 06:15:31PM -0300, Amador Pahim wrote:
On Tue, May 13, 2014 at 5:43 PM, Dan Kenigsberg <danken@redhat.com> wrote:
I'm using python-pep8-1.5.4-1.fc20.noarch
It seems like a bug in pep8 tool, and I see that it does not reproduce with v1.5.6 thereof.
I'm adding Matthias who may agree to backport the fix to Fedora 20 (or upgrade completely to 1.5.6)
Great, thank you.
I'd tend to upgrade to 1.5.6. I'll do that (nearly) immediately. - -- Matthias Runge <mrunge@redhat.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTc3giAAoJEOnz8qQwcaIWW/oH/Rio2vMcaZ0C2Lm6ya7Y5/Zu 9lndIrJDw5CfwL5ldIonabvuaOikfl9H2iKnJY2zxT97fkD6bhE9if4aFwW1FGxT UqDZf9nDkZQSQogdaaBgvQ69kupjk8kBYiaV8pc7OAgn/A//JWT0Np7r1/H/wp6C 8SRNqsCTbZ50Y1B5B6Rj4Nbuq/2aFsGgCNWysc3widygXNbBHD+pIqq6g2QK95Xc U5rMN5hCWPXpZ+hWe5tM2Ob0jFRWspyejKkh0Ya88DJD4eOMFzUJvpYKAkbBpfy4 Nw8PgB+73ZTYS5n9C8G8CeNhbwrE/KzZTrXnKgjKxsjn1XEKhWVa3cg8QIEKotc= =fqfO -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, May 13, 2014 at 06:15:31PM -0300, Amador Pahim wrote:
I'm using python-pep8-1.5.4-1.fc20.noarch
It seems like a bug in pep8 tool, and I see that it does not reproduce with v1.5.6 thereof.
I'm adding Matthias who may agree to backport the fix to Fedora 20 (or upgrade completely to 1.5.6)
Great, thank you.
This update is pushed to updates-testing (for f20), though due the system maintenance currently running, there was no mail sent about that. Please leave feedback on bodhi. Thanks Matthias - -- Matthias Runge <mrunge@redhat.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTc36pAAoJEOnz8qQwcaIW0vUIAIvZT+u1dd+1spAhlV1i9tQI TxL5RmVtR2cJj04n1t6usdZiJ1+g7w6PogDvbWyuJAnWZ5pt3zkbEFEgQOskYgf7 wxQ49sDegR5XTIOIZTvuK0N+bNqpRs9oQdepq1BLdNv+/2jZ4u8z79cZ2SGPDdA6 shAXFivi27Ty1d4g7P/850tfxOKo5Lv+SM6fZ1EL8X32OgEBdUTsB3nEgm9tWuH9 fyMaubu+J/TtyXitn/LubOe2uQVeNxZWXyXd/2iTxfbOoHfSBpUIvOKY0HJCu9aR BArznyifgsDGxdV9G/4jknqEfGjRwmvHGXPdkbv7ueaYk7AtiDDcna37/XDkQY8= =5ABq -----END PGP SIGNATURE-----
On Wed, May 14, 2014 at 04:33:13PM +0200, Matthias Runge wrote:
On Tue, May 13, 2014 at 06:15:31PM -0300, Amador Pahim wrote:
I'm using python-pep8-1.5.4-1.fc20.noarch
It seems like a bug in pep8 tool, and I see that it does not reproduce with v1.5.6 thereof.
I'm adding Matthias who may agree to backport the fix to Fedora 20 (or upgrade completely to 1.5.6)
Great, thank you.
This update is pushed to updates-testing (for f20), though due the system maintenance currently running, there was no mail sent about that. Please leave feedback on bodhi. Thanks
Thanks, but I do not get it with yum update --enablerepo=updates-testing python-pep8 nor see it in https://admin.fedoraproject.org/updates/search/python-pep8
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, May 15, 2014 at 10:15:33AM +0100, Dan Kenigsberg wrote:
This update is pushed to updates-testing (for f20), though due the system maintenance currently running, there was no mail sent about that. Please leave feedback on bodhi. Thanks
Thanks, but I do not get it with yum update --enablerepo=updates-testing python-pep8 nor see it in https://admin.fedoraproject.org/updates/search/python-pep8
Dan, I have the feeling, the update got lost and I submitted another (or the same?) update again. It should should show up in a few hours or in the next two days at updates-testing. Sorry for the inconvenience. Matthias - -- Matthias Runge <mrunge@redhat.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTdNuMAAoJEOnz8qQwcaIWmAwH/17xV3Y9qeTom/1+u9qaJbnK nis04wGuNVB3DB4sJHhl+QeKgW7AiaT6UlyAesJ9lO4WsmEZzeJrqh9d2dHdogu+ EmHZoqboNJ6sdDvmizt3qL6wL9pPWsFIFN875AxronY4d9UFTJx7UB04tzkP5ckK fpibBX//1jpUjgWe+36UDP0gsonFQ2DJod5tg+d780W423SF0rDQwpHfoFM5Y5pu JZQWaYc4oj3zfDVxIMuDIN447OdPeH5pnftavBZpb+mdc5pIMdicBQ8WUd4zA9qI QUZRWXX+sKwFvwDtjl2pTSz687lEUackTYdRaRZqr853/DNehq3x3dSw3OEsDFw= =4gyQ -----END PGP SIGNATURE-----
On Thu, May 15, 2014 at 05:21:48PM +0200, Matthias Runge wrote:
On Thu, May 15, 2014 at 10:15:33AM +0100, Dan Kenigsberg wrote:
This update is pushed to updates-testing (for f20), though due the system maintenance currently running, there was no mail sent about that. Please leave feedback on bodhi. Thanks
Thanks, but I do not get it with yum update --enablerepo=updates-testing python-pep8 nor see it in https://admin.fedoraproject.org/updates/search/python-pep8
Dan, I have the feeling, the update got lost and I submitted another (or the same?) update again. It should should show up in a few hours or in the next two days at updates-testing.
Sorry for the inconvenience.
Not at all. Thanks for the build. It has my kamra point.
participants (3)
-
Amador Pahim -
Dan Kenigsberg -
Matthias Runge