[ACTION REQUIRED] ovirt-engine build failing on master
*05:22:42* [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket)*05:22:42* [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java'*05:22:42* [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/... Please fix ASAP -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:04:30 AM Subject: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
05:22:42 [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
this should fix - but I need to verify it, will keep you updated https://gerrit.ovirt.org/50506
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Hi, it seems to like some CI issue, I just verified that local build works fine. I also looked at the job and last successful build is 8 days old ... Martin ----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:04:30 AM Subject: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
05:22:42 [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:24:50 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
Hi,
it seems to like some CI issue, I just verified that local build works fine. I also looked at the job and last successful build is 8 days old ...
it should reproduce only when you build with other than EN locale enabled since it is a mismatch between the UIMessages java and properties files
Martin
----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:04:30 AM Subject: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
05:22:42 [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Tomas Jelinek" <tjelinek@redhat.com> To: "Martin Perina" <mperina@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:27:23 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:24:50 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
Hi,
it seems to like some CI issue, I just verified that local build works fine. I also looked at the job and last successful build is 8 days old ...
it should reproduce only when you build with other than EN locale enabled since it is a mismatch between the UIMessages java and properties files
Ah, sorry I missed that.
Martin
----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:04:30 AM Subject: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
05:22:42 [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then? On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
*05:22:42* [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket)*05:22:42* [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java'*05:22:42* [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Tal Nisan" <tnisan@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Einav Cohen" <ecohen@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:29:17 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then?
This particular issue is only happening when you change a message which has already been in localized property files in a way that you change the num of parameters of it. This fixes it: https://gerrit.ovirt.org/#/c/50506/ Tested with 2 locales and seems to be working - Tal, adding you as a reviewer since you are already in the thread ;)
On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola < sbonazzo@redhat.com > wrote:
05:22:42 [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Acked, let me know if you need me to merge On Tue, Dec 15, 2015 at 12:36 PM, Tomas Jelinek <tjelinek@redhat.com> wrote:
----- Original Message -----
From: "Tal Nisan" <tnisan@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Einav Cohen" < ecohen@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:29:17 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then?
This particular issue is only happening when you change a message which has already been in localized property files in a way that you change the num of parameters of it.
This fixes it: https://gerrit.ovirt.org/#/c/50506/ Tested with 2 locales and seems to be working - Tal, adding you as a reviewer since you are already in the thread ;)
On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola < sbonazzo@redhat.com
wrote:
05:22:42 [INFO] [ERROR] Required argument 3 not
present:
{0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See
http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message -----
From: "Tal Nisan" <tnisan@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Einav Cohen" <ecohen@redhat.com>, "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 1:00:23 PM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
Acked, let me know if you need me to merge
Thanx, I will merge it as soon as jenkins passes.
On Tue, Dec 15, 2015 at 12:36 PM, Tomas Jelinek <tjelinek@redhat.com> wrote:
----- Original Message -----
From: "Tal Nisan" <tnisan@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Einav Cohen" < ecohen@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 11:29:17 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then?
This particular issue is only happening when you change a message which has already been in localized property files in a way that you change the num of parameters of it.
This fixes it: https://gerrit.ovirt.org/#/c/50506/ Tested with 2 locales and seems to be working - Tal, adding you as a reviewer since you are already in the thread ;)
On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola < sbonazzo@redhat.com
wrote:
05:22:42 [INFO] [ERROR] Required argument 3 not
present:
{0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See
http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
----- Original Message ----- From: "Tal Nisan" <tnisan@redhat.com> Sent: Tuesday, December 15, 2015 5:29:17 AM
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then?
(a) such patch cannot be merged because a unit-test, *even if ran during compilation for English only*, should fail (see [1]). @Alexander - can you please take a look at it with Tomas and see what happened (original patch merged without running unit-tests / problem with the unit-test itself [1] / ...)? (b) non-English .properties files should typically not be modified as part of regular patches (i.e. patches that are not dedicated "translation updates" which include updates to the files pulled directly from Zanata). *However*, there is one exception for that, and the exception is compilation error that happens due to the reason that you mentioned above - changes in English message variable-placeholders. In this case - the patch author must change the matching messages in the non- English .properties files to include the exact same variable-placeholders as the (updated) English message (i.e. remove placeholders / add placeholders as necessary). [1] http://lists.ovirt.org/pipermail/engine-commits/2014-October/018907.html
On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
*05:22:42* [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket)*05:22:42* [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java'*05:22:42* [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
(a) such patch cannot be merged because a unit-test, *even if ran during compilation for English only*, should fail (see [1]).
update: after discussing with Alexander: the unit-test doesn't cover the UIMessages file - that's why it was not detectable when compiling in English only. @Alexander - can you please extend the unit-test to include UIMessages? [1] https://gerrit.ovirt.org/#/c/32995/ ----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Tal Nisan" <tnisan@redhat.com>, "Alexander Wels" <awels@redhat.com>, "Tomas Jelinek" <tjelinek@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 7:30:40 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master
----- Original Message ----- From: "Tal Nisan" <tnisan@redhat.com> Sent: Tuesday, December 15, 2015 5:29:17 AM
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then?
(a) such patch cannot be merged because a unit-test, *even if ran during compilation for English only*, should fail (see [1]).
@Alexander - can you please take a look at it with Tomas and see what happened (original patch merged without running unit-tests / problem with the unit-test itself [1] / ...)?
(b) non-English .properties files should typically not be modified as part of regular patches (i.e. patches that are not dedicated "translation updates" which include updates to the files pulled directly from Zanata).
*However*, there is one exception for that, and the exception is compilation error that happens due to the reason that you mentioned above - changes in English message variable-placeholders. In this case - the patch author must change the matching messages in the non- English .properties files to include the exact same variable-placeholders as the (updated) English message (i.e. remove placeholders / add placeholders as necessary).
[1] http://lists.ovirt.org/pipermail/engine-commits/2014-October/018907.html
On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
*05:22:42* [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket)*05:22:42* [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java'*05:22:42* [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/...
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On Tuesday, December 15, 2015 03:11:41 PM Einav Cohen wrote:
(a) such patch cannot be merged because a unit-test, *even if ran during compilation for English only*, should fail (see [1]).
update: after discussing with Alexander: the unit-test doesn't cover the UIMessages file - that's why it was not detectable when compiling in English only.
@Alexander - can you please extend the unit-test to include UIMessages?
Patch that includes UIMessages is posted here [2] [2] https://gerrit.ovirt.org/#/c/50556
----- Original Message -----
From: "Einav Cohen" <ecohen@redhat.com> To: "Tal Nisan" <tnisan@redhat.com>, "Alexander Wels" <awels@redhat.com>, "Tomas Jelinek" <tjelinek@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Tuesday, December 15, 2015 7:30:40 AM Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master>
----- Original Message ----- From: "Tal Nisan" <tnisan@redhat.com> Sent: Tuesday, December 15, 2015 5:29:17 AM
Einav, it seems like an old issue we had when the default message contains the necessary placeholders but since no translations patch was released yet we don't have the placeholders in the translated messages, did we decide on a workaround back then?
(a) such patch cannot be merged because a unit-test, *even if ran during compilation for English only*, should fail (see [1]).
@Alexander - can you please take a look at it with Tomas and see what happened (original patch merged without running unit-tests / problem with the unit-test itself [1] / ...)?
(b) non-English .properties files should typically not be modified as part of regular patches (i.e. patches that are not dedicated "translation updates" which include updates to the files pulled directly from Zanata).
*However*, there is one exception for that, and the exception is compilation error that happens due to the reason that you mentioned above - changes in English message variable-placeholders. In this case - the patch author must change the matching messages in the non- English .properties files to include the exact same variable-placeholders as the (updated) English message (i.e. remove placeholders / add placeholders as necessary).
[1] http://lists.ovirt.org/pipermail/engine-commits/2014-October/018907.html>
On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola <sbonazzo@redhat.com>
wrote:
*05:22:42* [INFO] [ERROR] Required argument 3 not present: {0} ({1} Sockets, {2} Kerne pro Socket)*05:22:42* [INFO] [ERROR] Errors in 'org/ovirt/engine/ui/uicompat/ConstantsManager.java'*05:22:42* [INFO] [ERROR] Line 38: Failed to resolve 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
See http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x 86_64/682/console
Please fix ASAP
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
participants (6)
-
Alexander Wels -
Einav Cohen -
Martin Perina -
Sandro Bonazzola -
Tal Nisan -
Tomas Jelinek