Hi, just noticed today we are building on master a package named ovirt-jboss-modules-maven-plugin. The package is not required by any other package at spec file / rpm level and it has never been shipped in an official release as far as I can tell. Grep says we are using a java package through maven called ovirt-jboss-modules-maven-plugin in: - ovirt-engine - ovirt-engine-api-metamodel It doesn't seem we are bundling the library so it looks like a build time dependency only. Am I correct? Why aren't we adding it as BuildRequires to ovirt-engine spec file and keeping downloading it from maven central at every build instead of using system installed library? Thanks, -- SANDRO BONAZZOLA MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV Red Hat EMEA <https://www.redhat.com/> sbonazzo(a)redhat.com <https://red.ht/sig>

Il giorno lun 18 mar 2019 alle ore 09:42 Sandro Bonazzola < sbonazzo(a)redhat.com&gt; ha scritto: > Hi, didn't got a reply to this, raising again. > > Il giorno ven 8 mar 2019 alle ore 14:54 Sandro Bonazzola < > sbonazzo(a)redhat.com&gt; ha scritto: > >> Hi, >> just noticed today we are building on master a package >> named ovirt-jboss-modules-maven-plugin. >> The package is not required by any other package at spec file / rpm >> level and it has never been shipped in an official release as far as I can >> tell. >> Grep says we are using a java package through maven called >> ovirt-jboss-modules-maven-plugin in: >> - ovirt-engine >> - ovirt-engine-api-metamodel >> >> It doesn't seem we are bundling the library so it looks like a build >> time dependency only. Am I correct? >> >

Why aren't we adding it as BuildRequires to ovirt-engine spec file and >> keeping downloading it from maven central at every build instead of using >> system installed library? >> >> Pushed a patch for requiring it https://gerrit.ovirt.org/#/c/98720/

> Thanks, >> -- >> >> SANDRO BONAZZOLA >> >> MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV >> >> Red Hat EMEA <https://www.redhat.com/> >> >> sbonazzo(a)redhat.com >> <https://red.ht/sig> >> > > > -- > > SANDRO BONAZZOLA > > MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV > > Red Hat EMEA <https://www.redhat.com/> > > sbonazzo(a)redhat.com > <https://red.ht/sig> > -- SANDRO BONAZZOLA MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV Red Hat EMEA <https://www.redhat.com/> sbonazzo(a)redhat.com <https://red.ht/sig>