On Wed, 12 Dec 2018, 22:42 Marcin Sobczyk <msobczyk@redhat.com wrote:

Hi,

I've been working on adding coverage report for VDSM in OST recently, and I'm happy to announce, that the first batch of patches is merged!

To run a suite with coverage, look for 'COVERAGE' drop-down on OST's build parameters page. If you run OST locally, pass a '--coverage' argument to 'run_suite.sh'.

Currently, coverage works only for VDSM in basic-suite-master, but adding VDSM support for other suites is now a no-brainer. More patches are on the way!

Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other projects are welcome to implement their coverage reports on top of it.

Cheers, Marcin

Awesome indeed. I was not aware there's a way to add such parameters to suites. It could come up handy elsewhere (e.g. choosing ovs for cluster switchtype) I think it is important to explain why it's so important. Unfortunately, much of vdsm functionalily is not covered by proper vdsm unit tests. We depend on OST to define what is a "working" ovirt. Here's a message for us vdsm developers: if you care for your code and the time you've invested into it, make sure that it shows up green on the likes of https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests... The total number - 59% - is not brilliant, but not as bad as I assumed. Please go over the report. There are glaring missing pieces (e.g gluster, fencing) but also less obvious ones (almost half of vm.py). It should give you ideas about tests you need to add, or code you can drop.

Thanks for submitting it! it's really a great addition to the value OST gives, it can help prioritize which tests should be added in the future and also great timing, especially after the VDSM functional tests on check-merged were removed/pending removal in favor of running it on OST. On Wed, Dec 12, 2018 at 10:44 PM Marcin Sobczyk <msobczyk@redhat.com> wrote:

Hi,

I've been working on adding coverage report for VDSM in OST recently, and I'm happy to announce, that the first batch of patches is merged!

To run a suite with coverage, look for 'COVERAGE' drop-down on OST's build parameters page. If you run OST locally, pass a '--coverage' argument to 'run_suite.sh'.

Currently, coverage works only for VDSM in basic-suite-master, but adding VDSM support for other suites is now a no-brainer. More patches are on the way!

Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other projects are welcome to implement their coverage reports on top of it.

Cheers, Marcin

_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UDHD4SQLIGELWY...

-- Eyal edri MANAGER RHV/CNV DevOps EMEA VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

On 12/12/18 9:42 PM, Marcin Sobczyk wrote:

Hi,

I've been working on adding coverage report for VDSM in OST recently, and I'm happy to announce, that the first batch of patches is merged!

To run a suite with coverage, look for 'COVERAGE' drop-down on OST's build parameters page. If you run OST locally, pass a '--coverage' argument to 'run_suite.sh'.

Currently, coverage works only for VDSM in basic-suite-master, but adding VDSM support for other suites is now a no-brainer. More patches are on the way!

Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other projects are welcome to implement their coverage reports on top of it.

Cheers, Marcin

Kudos! very nice and very helpful addition. -- Francesco Romani Senior SW Eng., Virtualization R&D Red Hat IRC: fromani github: @fromanirh