[Kimchi-devel] Re: [PATCH] [Kimchi 0/3] Integrating with spice-web-client

Hi Aline, 1. No, just copy-paste:) 2. That is a bit tricky, how to let client know which spice to use? Added comment in PR. Created new pull without removing spice-html5 and without copyrights: https://github.com/kimchi-project/kimchi/pull/1225 Pavel On Apr 22, 2018, at 8:31 PM, aline.manera(a)gmail.com wrote: Hi Pavel! I checked the code and I have some suggestions: 1. The new files added for build do not need to contain the IBM copyright as you did not that for IBM (or did you do?) 2. For the new functionality itself, I'd propose to add a build parameter, something like --with-spice-web-client to build the app with spice-web-client, otherwise, use spice-html5. That way, we can have a easier way to move forward with Linux distribution repositories which does not allow third-part JS files into the package. What do you think about that? Regards, On Tue, Apr 3, 2018 at 11:46 AM, Pavel Gurenko <pgurenko(a)gmail.com&gt; wrote: > If you mean the ones before installing spice guest tools (two cursors), > then no, I guess it's not. > I had no issues with spice guest tools installed. > > On Tue, Apr 3, 2018, 2:13 AM Joni Orponen <j.orponen(a)4teamwork.ch&gt; wrote: > >> On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <pgurenko(a)gmail.com&gt; >> wrote: >> >>> The spice-html5 does not support the qxl drivers for Windows VMs and it >>> looks like qxl has the best performance for now. >>> While spice-html5 is more like proof-of-concept, a bit slow and in >>> general not really supported right now. >>> >>> On the other hand, spice-web-client is performant, production solution >>> and supports almost everything the spice can support. >>> >>> The pull request is mostly the drop-in replacement, spice-html5 web >>> client JavaScript gets replaced with spice-web-client JavaScript. >>> I used the latest version of spice-web-client from github: >>> https://github.com/eyeos/spice-web-client - unfortunately guys don't >>> have releases in CDN. >>> >> >> Would this also get rid of mouse acceleration mismatch issues with >> Windows clients? >> >> -- >> Joni Orponen >> _______________________________________________ >> Kimchi-devel mailing list >> Kimchi-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/kimchi-devel >> > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel > > -- Aline Manera