Re: [Kimchi-devel] [PATCH 4/4] pep8: Use consistent line spacing
Am 20-01-2014 13:38, schrieb Aline Manera:
> _ports = {}
>
> +
> fake_user = {'admin': 'letmein!'}
>
> +
Can't we have one single block for all constants?
Sure!
Those two statements were already separated by one line, I just add
another one to comply with PEP8. I didn't mean to change the code
structure, only to add one more line where there was already a
separating line. Maybe those two variables are not related (other than
being global variables on the same file) and they shouldn't be grouped
together. That wasn't my patch's goal.
But of course I can group them together if you want to.
I'm preparing a new and rebased patchset.