Re: [Kimchi-devel] [PATCH 0/2 V5] UI for LDAP
The tab "Permission" added an unnecessary scroll bar to the left. In
previous commits*, that scroll bar didn't exist. Check the attached image.
I'm using Chrome 39.0.2171.71 (64-bit) on Fedora 20.
* Actually, the command "GET /host/users" is not working here since
commit 5846a81 ("Split users and groups for permission query") with the
message "Nothing matches the given URI" (404), so the tab "Permission"
is empty in the current master branch, without applying this patchset.
Even with that empty list or with a filled list (from commits prior to
that one), that scroll bar didn't exist, so it's been added by this
patchset.
On 26-11-2014 15:17, Aline Manera wrote:
v1 > v2,
Change according to LDAP backend api change.
v2 > v3,
Change alert icon to red border of input box to be more clear,
commented by YuXin
v3 > v4,
Fix alignment and use place holder to inform user what to fill.
commented by Aline.
v4 > v5,
Use cached capabilities values and rename functions
Royce Lv (2):
UI: support ldap vm permission tag
Change guest edit permission logic
ui/css/theme-default/guest-edit.css | 94 ++++++++++++++++--------
ui/js/src/kimchi.api.js | 23 ++++--
ui/js/src/kimchi.guest_edit_main.js | 140 +++++++++++++++++++++++++++++-------
ui/pages/guest-edit.html.tmpl | 22 +++++-
4 files changed, 217 insertions(+), 62 deletions(-)
Attachments:
- users.png (image/png — 32.9 KB)
