If I could be a little pedantic, I think that the lesson we can take
from this is that we should always give our colleagues the "benefit of
the doubt." IOW: assume a perceived wrong as an honest mistake instead
of an intentional bad behavior. And if in doubt, just ask!
On Tue, 2014-02-25 at 19:58 -0300, Aline Manera wrote:
On 02/25/2014 05:51 AM, Shu Ming wrote:
> As you have seen, we have author information in Kimchi source code to
> specially honour the writer of the original source files and the
> succeeding writers with substantial change. Unfortunately, I found the
> authors in some files were updated without any substantial change. One
> recent example about this is "src/kimchi/model/debugreports.py", the
> author was changed to "Aline Manera" and the original author was gone.
> And this change was introduced by "refactor model: Create a separated
> model for debug report resource" that got a new file
> split from another huge file without much change. I don't think this
> split was deserved to change the author in the new file. Then, how do we
> define what is "substantial change". I would say it is a new feature
> changing the file with more than 1/3 of the total lines of code. It is a
> not necessary a hard rule, but it is obvious that code split should not
> be deserved to have a new author for the file.
Sorry, Ming, about that.
I created the license header on model/__init__.py and used it in all new
files I created for
refactoring model task.
My intention was not get credits from a work I didn't do.
And if you see in the former model.py (commit
Adam Litke is listed as the author so, from what you wrote above, I
should keep him as the author
for *all* files created during refactor model.
**But** everyone knows everyone had contributed to model.py as well for
any other file in Kimchi
So I am wondering why to have the name listed there became so important
You don't need to have your name listed there to get credits or honor
for a work you did.
git log is there to show all the contributions, the same for github
About the issue you mentioned, I was more concerned about getting the
refactor model done
than check line by line to identify who had written it.
We also have the AUTHORS file which list everyone as contributors to Kimchi.
> Kimchi-devel mailing list
Kimchi-devel mailing list