8:44 p.m.
make-check fails
/usr/bin/pep8 --filename '*.py,*.py.in' plugins/__init__.py
plugins/sample/__init__.py plugins/sample/model.py
src/kimchi/asynctask.py src/kimchi/auth.py src/kimchi/cachebust.py
src/kimchi/config.py.in src/kimchi/control/*.py
src/kimchi/control/vm/*.py src/kimchi/disks.py
src/kimchi/distroloader.py src/kimchi/exception.py
src/kimchi/featuretests.py src/kimchi/iscsi.py src/kimchi/isoinfo.py
src/kimchi/kvmusertests.py src/kimchi/mockmodel.py src/kimchi/model/*.py
src/kimchi/osinfo.py src/kimchi/repositories.py
src/kimchi/rollbackcontext.py src/kimchi/root.py src/kimchi/server.py
src/kimchi/swupdate.py src/kimchi/utils.py tests/test_config.py.in
tests/test_mockmodel.py tests/test_model.py tests/test_osinfo.py
tests/test_plugin.py tests/test_rest.py tests/test_rollbackcontext.py
tests/test_storagepool.py tests/utils.py
src/kimchi/model/storagepools.py:168:1: E302 expected 2 blank lines, found 1
src/kimchi/model/storagevolumes.py:143:34: E128 continuation line
under-indented for visual indent
src/kimchi/model/storagevolumes.py:148:48: E231 missing whitespace after ','
src/kimchi/model/vms.py:190:21: E128 continuation line under-indented
for visual indent
src/kimchi/model/vms.py:429:17: E128 continuation line under-indented
for visual indent
src/kimchi/model/vms.py:431:1: E302 expected 2 blank lines, found 1
src/kimchi/model/vms.py:453:17: E128 continuation line under-indented
for visual indent
src/kimchi/model/vms.py:471:17: E128 continuation line under-indented
for visual indent
make[2]: *** [check-local] Error 1
make[2]: Leaving directory `/home/alinefm/kimchi'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/alinefm/kimchi'
make: *** [check-recursive] Error 1
On 03/28/2014 01:40 PM, Rodrigo Trujillo wrote:
V3:
- Fix issues with tests
- Rebase with 1.2
V2:
Address Aline's comments:
- Change error message
- Aggregate 'if's
V1:
If the disk where objectstore (Kimchi database) is full, then a lot of
errors will be raised without any special treatment. This can lead the
system to an unexpected state.
This patchset modifies kimchi in order to give the right treatment to
exceptions, showing the error to the user or hidding when possible.
Rodrigo Trujillo (5):
Fix 'disk full' issue: Change objectstore exception handling
Fix 'disk full' issue: Fix Templates db store/delete error handling
Fix 'disk full' issue: Fix storage volume error handling
Fix 'disk full' issue: Fix storagepool and asynctasks error handling
Fix 'disk full' issue: Fix vms/screenshot db store/delete error
handling
src/kimchi/asynctask.py | 7 ++--
src/kimchi/i18n.py | 5 +++
src/kimchi/model/storagepools.py | 8 +++--
src/kimchi/model/storagevolumes.py | 49 ++++++++++++++++----------
src/kimchi/model/templates.py | 27 +++++++++++----
src/kimchi/model/vms.py | 70 +++++++++++++++++++++++++++-----------
src/kimchi/objectstore.py | 7 ++++
7 files changed, 123 insertions(+), 50 deletions(-)