Re: [Kimchi-devel] [PATCH][Kimchi] Issue #116: Suggestion to check spec guidelines

On Jun 16 12:05PM, Ramon Medeiros wrote: > Run rpmlint on check-local > > Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com&gt; > --- > Makefile.am | 1 + > check_spec_errors.sh | 34 ++++++++++++++++++++++++++++++++++ > docs/fedora-deps.md | 2 +- > docs/opensuse-deps.md | 2 +- > 4 files changed, 37 insertions(+), 2 deletions(-) > create mode 100755 check_spec_errors.sh > > diff --git a/Makefile.am b/Makefile.am > index 1b46773..85a44bc 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -83,6 +83,7 @@ check-local: > echo "IBM copyright year verification ..." ; \ > /bin/bash ../../../../check-IBM-license-header.sh ; \ > fi > + ./check_spec_errors.sh This will be executed in all kind of distro, doesn't?. Since the check_spec_errors.sh executes rpmlint, you must execute it only in RPM-based

distros. We can add a distro checking here or in the check_spec_errors.sh (where I prefer). > # Link built mo files in the source tree to enable use of translations from > # within the source tree > diff --git a/check_spec_errors.sh b/check_spec_errors.sh > new file mode 100755 > index 0000000..b25da58 > --- /dev/null > +++ b/check_spec_errors.sh > @@ -0,0 +1,34 @@ > +#!/bin/bash > + > +# > +# Project Wok > +# > +# Copyright IBM Corp, 2015-2016 > +# > +# This library is free software; you can redistribute it and/or > +# modify it under the terms of the GNU Lesser General Public > +# License as published by the Free Software Foundation; either > +# version 2.1 of the License, or (at your option) any later version. > +# > +# This library is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +# Lesser General Public License for more details. > +# > +# You should have received a copy of the GNU Lesser General Public > +# License along with this library; if not, write to the Free Software > +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + > +# create links > +cp contrib/kimchi.spec.fedora contrib/kimchi_fedora.spec > +cp contrib/kimchi.spec.suse contrib/kimchi_suse.spec > + > +# run checking > +rpmlint contrib/kimchi_fedora.spec > +rpmlint contrib/kimchi_suse.spec > + > +# remove links > +rm contrib/kimchi_fedora.spec > +rm contrib/kimchi_suse.spec > + > + > diff --git a/docs/fedora-deps.md b/docs/fedora-deps.md > index ca24994..65ad987 100644 > --- a/docs/fedora-deps.md > +++ b/docs/fedora-deps.md > @@ -47,7 +47,7 @@ Packages required for UI development > Packages required for tests > --------------------------- > > - $ sudo yum install pyflakes python-pep8 python-requests python-mock > + $ sudo yum install pyflakes python-pep8 python-requests python-mock rpmlint > > # For RHEL systems, install the additional packages: > $ sudo yum install python-unittest2 > diff --git a/docs/opensuse-deps.md b/docs/opensuse-deps.md > index a8763b3..16ffb5e 100644 > --- a/docs/opensuse-deps.md > +++ b/docs/opensuse-deps.md > @@ -45,4 +45,4 @@ Packages required for UI development > Packages required for tests > --------------------------- > > - $ sudo zypper install python-pyflakes python-pep8 python-requests python-mock > + $ sudo zypper install python-pyflakes python-pep8 python-requests python-mock rpmlint > -- > 2.5.5 > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel > -- Paulo Ricardo Paz Vital Linux Technology Center, IBM Systems http://www.ibm.com/linux/ltc/ _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel