Re: [Kimchi-devel] [PATCHv3] [Kimchi] Create Template UI adjustments including size and loading

Hi Socorro, Although this version has the loading icon, it added a right content shift when the loading icon is removed to display the ISOs. As I had more suggestions to make, I preferred to apply V2 and get one patch with all the improvements at once. Hope you don't mind. =) Regards, Aline Manera On 04/20/2016 06:45 PM, Socorro Stoppler wrote: > v3: > Added loading icon since at times, it takes a while for the ISOs to load > > v2: > Added 'Not Available' for size to be displayed when there's no value > for size; otherwise, the container for the templates are showing up > as different sizes due to missing value for the size field. Also > moved the local/remote iso icon to bottom right corner > > v1: > This is a brand new patch to implement create template UI without the > user > having to distinguish between iso and image files since the original > one wasn't done quite right. Therefore, please ignore the original > patch > and this is v1. > > There are no longer any radio buttons, all the remote and local isos, > if any, > are displayed in the same panel and are distinguished by having a > 'globe' icon for > remote and a 'hdd' icon for local at the top left corner of each > tile. Also, > filtering by typing in the textbox has been added. > > Socorro Stoppler (1): > Create Template UI adjustments based on feedback; added Not > Available to be displayed for Size when there's no size and move > remote/local iso icon to bottom right; add loading icon > > ui/css/kimchi.css | 36 ++++ > ui/css/src/modules/_templates.scss | 30 +++ > ui/js/src/kimchi.template_add_main.js | 342 > +++++++--------------------------- > ui/pages/i18n.json.tmpl | 1 + > ui/pages/template-add.html.tmpl | 88 ++------- > 5 files changed, 148 insertions(+), 349 deletions(-) >