Re: [Kimchi-devel] [Wok][PATCH v2 4/7] Multi-Culture support : Format datetime as per locale in wok.list.js

On 05/05/2016 04:02 AM, pkulkark(a)linux.vnet.ibm.com wrote: > From: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com&gt; > > co-authored by: Archana Singh <archus(a)linux.vnet.ibm.com&gt; > > v2: > Modified call to fetch locale > > v1: > This patch formats the datetime fields as per locale > in wok-list widget. > > Signed-off-by: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com&gt; > --- > ui/js/src/wok.list.js | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/ui/js/src/wok.list.js b/ui/js/src/wok.list.js > index f40b2e2..8f02fde 100644 > --- a/ui/js/src/wok.list.js > +++ b/ui/js/src/wok.list.js > @@ -123,6 +123,10 @@ wok.widget.List.prototype = (function() { > var checkboxName = $('ul', > container).parent().parent().parent().attr('id') + '-check' || > $(container).parent().parent().parent().attr('id') + '-check'; > $.each(fields, function(fi, field) { > var value = getValue(field.name, row); > + if (field.name === 'time') { > + var dte = new > Date(value.substr(0,10)+'T'+value.substr(11)) > + value = > dte.toLocaleString(wok.lang.get_locale()) > + wok.list.js is a generic widget, ie, it will only display the data in a given visual format. Any data logic should be done prior to it. wok.list.js will not be aware about which data to do the conversion. Assuming the field will have a 'name' as 'time' is dangerous IMO. We can have different fields for datetime which does not have a name=time on it.

> } > if (field.type === 'status' && field.name === > 'enabled') { > styleClass = (value === true ? '' : ' > disabled'); > state = [ > @@ -299,4 +303,4 @@ wok.widget.List.prototype = (function() { > reload: reload, > showMessage: showMessage > }; > -})(); > \ No newline at end of file > +})(); _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel