[PATCH] Bug #361. Network Action Dropdown does not Disappear when mouse out
From: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com> Signed-off-by: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com> --- ui/js/src/kimchi.network.js | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ui/js/src/kimchi.network.js b/ui/js/src/kimchi.network.js index 1642b99..9fa8324 100644 --- a/ui/js/src/kimchi.network.js +++ b/ui/js/src/kimchi.network.js @@ -149,6 +149,9 @@ kimchi.addNetworkActions = function(network) { }).click(function() { $(".menu-container", "#" + network.name).toggle(); window.scrollBy(0, 150); + }).mouseleave(function() { + var delay = setTimeout(function(){$(".menu-container", "#"+network.name).toggle(false);}, 500); + $(".menu-container", "#"+network.name).mouseenter(function(){clearTimeout(delay);}); }); $(".menu-container", "#" + network.name).mouseleave(function() { $(".menu-container", "#" + network.name).toggle(false); -- 1.7.1
Reviewed-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> I tested in Firefox, Fedora20. This patch fixes the problem. However, I would like to notice that the behaviour is not the same like other tabs: - guest, templates, storage tabs: drop-down menu remain opened until user click click in something else, like the "+" button - network tab: drop-down menu remain opened only if user keeps mouse on it. On 04/02/2014 06:20 AM, huoyuxin@linux.vnet.ibm.com wrote:
From: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com>
Signed-off-by: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com> --- ui/js/src/kimchi.network.js | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/ui/js/src/kimchi.network.js b/ui/js/src/kimchi.network.js index 1642b99..9fa8324 100644 --- a/ui/js/src/kimchi.network.js +++ b/ui/js/src/kimchi.network.js @@ -149,6 +149,9 @@ kimchi.addNetworkActions = function(network) { }).click(function() { $(".menu-container", "#" + network.name).toggle(); window.scrollBy(0, 150); + }).mouseleave(function() { + var delay = setTimeout(function(){$(".menu-container", "#"+network.name).toggle(false);}, 500); + $(".menu-container", "#"+network.name).mouseenter(function(){clearTimeout(delay);}); }); $(".menu-container", "#" + network.name).mouseleave(function() { $(".menu-container", "#" + network.name).toggle(false);
On 04/02/2014 11:00 AM, Rodrigo Trujillo wrote:
Reviewed-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com>
I tested in Firefox, Fedora20. This patch fixes the problem. However, I would like to notice that the behaviour is not the same like other tabs: - guest, templates, storage tabs: drop-down menu remain opened until user click click in something else, like the "+" button - network tab: drop-down menu remain opened only if user keeps mouse on it.
Well remembered, Rodrigo! We should be consistent in that and apply the same behavior in all tabs.
On 04/02/2014 06:20 AM, huoyuxin@linux.vnet.ibm.com wrote:
From: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com>
Signed-off-by: Yu Xin Huo <huoyuxin@linux.vnet.ibm.com> --- ui/js/src/kimchi.network.js | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/ui/js/src/kimchi.network.js b/ui/js/src/kimchi.network.js index 1642b99..9fa8324 100644 --- a/ui/js/src/kimchi.network.js +++ b/ui/js/src/kimchi.network.js @@ -149,6 +149,9 @@ kimchi.addNetworkActions = function(network) { }).click(function() { $(".menu-container", "#" + network.name).toggle(); window.scrollBy(0, 150); + }).mouseleave(function() { + var delay = setTimeout(function(){$(".menu-container", "#"+network.name).toggle(false);}, 500); + $(".menu-container", "#"+network.name).mouseenter(function(){clearTimeout(delay);}); }); $(".menu-container", "#" + network.name).mouseleave(function() { $(".menu-container", "#" + network.name).toggle(false);
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
participants (3)
-
Aline Manera -
huoyuxin＠linux.vnet.ibm.com -
Rodrigo Trujillo