9:49 a.m.
The following patch fixes the issue described in Github #354:
"storage: used nfs source path need to be filtered out in creation page"
https://github.com/kimchi-project/kimchi/issues/354
Daniel Henrique Barboza (1):
model/storagetargets: filtering used nfs paths
src/kimchi/model/storagetargets.py | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
--
1.8.3.1
9:49 a.m.
New subject: [PATCH] model/storagetargets: filtering used nfs paths
As described in Github issue #354, this patch filters the storage
targets list to not show the nfs paths that are in use by an
existing NFS pool.
Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
---
src/kimchi/model/storagetargets.py | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/src/kimchi/model/storagetargets.py b/src/kimchi/model/storagetargets.py
index 6f29a49..726624f 100644
--- a/src/kimchi/model/storagetargets.py
+++ b/src/kimchi/model/storagetargets.py
@@ -57,6 +57,29 @@ class StorageTargetsModel(object):
targets = self._parse_target_source_result(target_type, ret)
target_list.extend(targets)
+
+ if 'netfs' in target_types:
+ # Get all netfs pools to determine which nfs paths are in use
+ nfs_paths_used = []
+ try:
+ conn = self.conn.get()
+ pools = conn.listAllStoragePools(
+ libvirt.VIR_CONNECT_LIST_STORAGE_POOLS_NETFS)
+ for pool in pools:
+ pool_xml = pool.XMLDesc(0)
+ root = objectify.fromstring(pool_xml)
+ if root.source.dir is not None:
+ nfs_paths_used.append(root.source.dir.get('path'))
+
+ except libvirt.libvirtError as e:
+ err = "Query storage pool source fails because of %s"
+ kimchi_log.warning(err, e.get_error_message())
+ continue
+
+ # Filter target_list to not not show the used nfs paths
+ target_list = [elem for elem in target_list
+ if elem.get('target') not in nfs_paths_used]
+
return target_list
def _get_storage_server_spec(self, **kwargs):
--
1.8.3.1
10:12 a.m.
New subject: [PATCH] model/storagetargets: filtering used nfs paths
This patch breaks the tests. Please run "make check" before submitting
patches.
On 19-08-2014 11:49, Daniel Henrique Barboza wrote:
As described in Github issue #354, this patch filters the storage
targets list to not show the nfs paths that are in use by an
existing NFS pool.
Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
11:48 a.m.
New subject: [PATCH] model/storagetargets: filtering used nfs paths
I've fixed the part of the patch that breaks it and will send a v2.
However, I must say that make check does not complete successfully in
master due to failures/errors that this patch can't and shouldn't be
accounted for:
======================================================================
ERROR: test_delete_running_vm (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 1062, in test_delete_running_vm
inst.templates_create(params)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create
user = UserTests().probe_user()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py", line
56, in probe_user
dom.create()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in create
if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_template_clone (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 693, in test_template_clone
inst.templates_create(orig_params)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create
user = UserTests().probe_user()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py", line
56, in probe_user
dom.create()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in create
if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_template_create (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 613, in test_template_create
self.assertRaises(InvalidParameter, inst.templates_create, params)
File "/usr/lib64/python2.7/unittest/case.py", line 513, in assertRaises
callableObj(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create
user = UserTests().probe_user()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py", line
56, in probe_user
dom.create()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in create
if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_vm_cdrom (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 400, in test_vm_cdrom
cdrom_dev = inst.vmstorages_create(vm_name, cdrom_args)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vmstorages.py",
line 178, in create
raise OperationFailed("KCHVMSTOR0008E", {'error': e.message})
OperationFailed: KCHVMSTOR0008E: Error while creating new storage
device: internal error unknown protocol type 'http'
======================================================================
ERROR: test_vm_lifecycle (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 101, in test_vm_lifecycle
inst.vm_start('kimchi-vm')
File "/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py",
line 542, in start
{'name': name, 'err': e.get_error_message()})
OperationFailed: KCHVM0019E: Unable to start virtual machine kimchi-vm.
Details: monitor socket did not show up: No such file or directory
======================================================================
FAIL: test_debug_reports (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 1151, in test_debug_reports
"It is not necessary an error. "
AssertionError: It is not necessary an error. You may need to increase
the timeout number by TEST_REPORT_TIMEOUT=200 ./run_tests.sh test_model
----------------------------------------------------------------------
Ran 161 tests in 357.586s
FAILED (failures=1, errors=5, skipped=2)
On 08/19/2014 12:12 PM, Crístian Viana wrote:
This patch breaks the tests. Please run "make check" before
submitting
patches.
On 19-08-2014 11:49, Daniel Henrique Barboza wrote:
> As described in Github issue #354, this patch filters the storage
> targets list to not show the nfs paths that are in use by an
> existing NFS pool.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
1:07 p.m.
New subject: [PATCH] model/storagetargets: filtering used nfs paths
Wohoo! What is your OS?
I run on Fedora 20 and I don't see those errors.
On 08/19/2014 01:48 PM, Daniel H Barboza wrote:
I've fixed the part of the patch that breaks it and will send a
v2.
However, I must say that make check does not complete successfully in
master due to failures/errors that this patch can't and shouldn't be
accounted for:
======================================================================
ERROR: test_delete_running_vm (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 1062, in test_delete_running_vm
inst.templates_create(params)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create
user = UserTests().probe_user()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py",
line 56, in probe_user
dom.create()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in
create
if ret == -1: raise libvirtError ('virDomainCreate() failed',
dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_template_clone (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 693, in test_template_clone
inst.templates_create(orig_params)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create
user = UserTests().probe_user()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py",
line 56, in probe_user
dom.create()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in
create
if ret == -1: raise libvirtError ('virDomainCreate() failed',
dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_template_create (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 613, in test_template_create
self.assertRaises(InvalidParameter, inst.templates_create, params)
File "/usr/lib64/python2.7/unittest/case.py", line 513, in assertRaises
callableObj(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create
user = UserTests().probe_user()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py",
line 56, in probe_user
dom.create()
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper
ret = f(*args, **kwargs)
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in
create
if ret == -1: raise libvirtError ('virDomainCreate() failed',
dom=self)
libvirtError: monitor socket did not show up: No such file or directory
======================================================================
ERROR: test_vm_cdrom (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 400, in test_vm_cdrom
cdrom_dev = inst.vmstorages_create(vm_name, cdrom_args)
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vmstorages.py", line
178, in create
raise OperationFailed("KCHVMSTOR0008E", {'error': e.message})
OperationFailed: KCHVMSTOR0008E: Error while creating new storage
device: internal error unknown protocol type 'http'
======================================================================
ERROR: test_vm_lifecycle (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 101, in test_vm_lifecycle
inst.vm_start('kimchi-vm')
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py", line
542, in start
{'name': name, 'err': e.get_error_message()})
OperationFailed: KCHVM0019E: Unable to start virtual machine
kimchi-vm. Details: monitor socket did not show up: No such file or
directory
======================================================================
FAIL: test_debug_reports (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 1151, in test_debug_reports
"It is not necessary an error. "
AssertionError: It is not necessary an error. You may need to
increase the timeout number by TEST_REPORT_TIMEOUT=200 ./run_tests.sh
test_model
----------------------------------------------------------------------
Ran 161 tests in 357.586s
FAILED (failures=1, errors=5, skipped=2)
On 08/19/2014 12:12 PM, Crístian Viana wrote:
> This patch breaks the tests. Please run "make check" before
> submitting patches.
>
> On 19-08-2014 11:49, Daniel Henrique Barboza wrote:
>> As described in Github issue #354, this patch filters the storage
>> targets list to not show the nfs paths that are in use by an
>> existing NFS pool.
>>
>> Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel
1:11 p.m.
New subject: [PATCH] model/storagetargets: filtering used nfs paths
On 19-08-2014 15:07, Aline Manera wrote:
Wohoo! What is your OS?
I run on Fedora 20 and I don't see those errors.
Neither do I. I think there's something wrong in his environment and the
tests fail because of that. I only get an error at
"test_delete_running_vm", but that's a known failure on Fedora 20.
I don't know what's happening on his system, but those errors don't
happen on mine.
3:08 p.m.
New subject: [PATCH] model/storagetargets: filtering used nfs paths
On 08/19/2014 03:11 PM, Crístian Viana wrote:
On 19-08-2014 15:07, Aline Manera wrote:
>
> Wohoo! What is your OS?
>
> I run on Fedora 20 and I don't see those errors.
>
Neither do I. I think there's something wrong in his environment and
the tests fail because of that. I only get an error at
"test_delete_running_vm", but that's a known failure on Fedora 20.
I don't know what's happening on his system, but those errors don't
happen on mine.
Fedora 19
3547
days inactive
3547
days old
6 comments
4 participants
participants (4)
-
Aline Manera -
Crístian Viana -
Daniel H Barboza -
Daniel Henrique Barboza