[PATCH] [Kimchi 0/3] Multiple string truncation issue fixed
From: Rajat Gupta <rajat.triumph@gmail.com> Rajat Gupta (3): Fixed for Truncation occurs in edit a guest panel console row Fixed Truncation appeared on Virtualization->add network of Japanese language Fixed truncation for Guest Interface GUI OVS network/interface scroll bar ui/css/src/modules/_edit-guests.scss | 2 +- ui/css/src/modules/_network.scss | 8 ++++++++ ui/js/src/kimchi.guest_edit_main.js | 4 +++- 3 files changed, 12 insertions(+), 2 deletions(-) -- 2.1.0
From: Rajat Gupta <rajat.triumph@gmail.com> Fixed for Truncation occurs in edit a guest panel console row Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/css/src/modules/_edit-guests.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/css/src/modules/_edit-guests.scss b/ui/css/src/modules/_edit-guests.scss index 25d4d65..fd43822 100644 --- a/ui/css/src/modules/_edit-guests.scss +++ b/ui/css/src/modules/_edit-guests.scss @@ -19,7 +19,7 @@ #guest-edit-window { .tab-content { overflow: hidden; - height: 559px; + height: auto; } .tab-content .tab-pane { position: relative; -- 2.1.0
You need to run "make -C ui/css css" to get the css updated as well and added it to your commit. On 01/24/2017 08:37 AM, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Fixed for Truncation occurs in edit a guest panel console row
Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/css/src/modules/_edit-guests.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/css/src/modules/_edit-guests.scss b/ui/css/src/modules/_edit-guests.scss index 25d4d65..fd43822 100644 --- a/ui/css/src/modules/_edit-guests.scss +++ b/ui/css/src/modules/_edit-guests.scss @@ -19,7 +19,7 @@ #guest-edit-window { .tab-content { overflow: hidden; - height: 559px; + height: auto; } .tab-content .tab-pane { position: relative;
From: Rajat Gupta <rajat.triumph@gmail.com> Fixed Truncation appeared on Virtualization->add network of Japanese language Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/css/src/modules/_network.scss | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ui/css/src/modules/_network.scss b/ui/css/src/modules/_network.scss index 5cedb0f..cb39502 100644 --- a/ui/css/src/modules/_network.scss +++ b/ui/css/src/modules/_network.scss @@ -124,3 +124,11 @@ } } + +#add-network-window { + #networkConfig { + #alert-modal-container .alert { + padding: 8px 34px 8px 16px; + } + } +} -- 2.1.0
The same I commented related to the css file. On 01/24/2017 08:37 AM, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Fixed Truncation appeared on Virtualization->add network of Japanese language
Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/css/src/modules/_network.scss | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/ui/css/src/modules/_network.scss b/ui/css/src/modules/_network.scss index 5cedb0f..cb39502 100644 --- a/ui/css/src/modules/_network.scss +++ b/ui/css/src/modules/_network.scss @@ -124,3 +124,11 @@ }
} + +#add-network-window { + #networkConfig { + #alert-modal-container .alert { + padding: 8px 34px 8px 16px; + } + } +}
From: Rajat Gupta <rajat.triumph@gmail.com> Fixed for Guest Interface GUI -- OVS network/interface scroll bar was truncated when there are more than 20+ ovs bridges on the host. Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/js/src/kimchi.guest_edit_main.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest_edit_main.js index b47d293..bfc5c38 100644 --- a/ui/js/src/kimchi.guest_edit_main.js +++ b/ui/js/src/kimchi.guest_edit_main.js @@ -230,7 +230,9 @@ kimchi.guest_edit_main = function() { $("select", "span.column-network", itemNode).append(networkOptions); } - $("select", itemNode).selectpicker(); + $("select", itemNode).selectpicker({ + dropupAuto: false + }); $('.edit', itemNode).attr('disabled', kimchi.thisVMState === "running"); -- 2.1.0
Reviewed-By: Lucio Correia <luciojhc@linux.vnet.ibm.com> On 24/01/2017 08:37, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Rajat Gupta (3): Fixed for Truncation occurs in edit a guest panel console row Fixed Truncation appeared on Virtualization->add network of Japanese language Fixed truncation for Guest Interface GUI OVS network/interface scroll bar
ui/css/src/modules/_edit-guests.scss | 2 +- ui/css/src/modules/_network.scss | 8 ++++++++ ui/js/src/kimchi.guest_edit_main.js | 4 +++- 3 files changed, 12 insertions(+), 2 deletions(-)
-- Lucio Correia
Please, also make sure to run "make check-local" to confirm everything is on the place and also get the copyright date updated. On 01/24/2017 08:37 AM, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Rajat Gupta (3): Fixed for Truncation occurs in edit a guest panel console row Fixed Truncation appeared on Virtualization->add network of Japanese language Fixed truncation for Guest Interface GUI OVS network/interface scroll bar
ui/css/src/modules/_edit-guests.scss | 2 +- ui/css/src/modules/_network.scss | 8 ++++++++ ui/js/src/kimchi.guest_edit_main.js | 4 +++- 3 files changed, 12 insertions(+), 2 deletions(-)
participants (3)
-
Aline Manera -
Lucio Correia -
rajgupta＠linux.vnet.ibm.com