[Engine-devel] find-bugs errors

[Vojtech Szocs]

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Moti Asayag" <masayag at redhat.com>, "Vojtech Szocs" <vszocs at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Tuesday, January 21, 2014 10:41:24 PM
> Subject: find-bugs errors
> 
> (1) @Moti: see [1] and [2]. it seems that they were caused by
> http://gerrit.ovirt.org/#/c/23507/
> 
> (2) @Vojtech[/UI Maintainers/others]: see [3] - it seems that the UI's
> AppErrors.java file
> became too large for find-bugs to handle. Any ideas on how to handle this
> (add to ignore list/
> divide to several files/...)?

As far as I can tell, FindBugs has hard-coded limit of class size (1M) && method count (1K). Any class exceeding these limits will be skipped with SKIPPED_CLASS_TOO_BIG warning. See [a] for details.

In WebAdmin we already exclude ApplicationConstants from SKIPPED_CLASS_TOO_BIG warning [b]. I suggest to do the same for AppErrors. Dividing AppErrors into smaller files doesn't make sense as this is GWT i18n interface that only contains i18n constant keys with default values, no logic whatsoever.

[a] http://sourceforge.net/p/findbugs/feature-requests/260/
[b] frontend/webadmin/modules/webadmin/exclude-filters.xml

Vojtech

> 
> 
> [1]
> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.27/#386
> 
> [2]
> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.28/#387
> 
> [3]
> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1188557915/
> 
> ----- Forwarded Message -----
> From: "Jenkins ci oVirt Server" <jenkins at ovirt.org>
> To: engine-patches at ovirt.org, fsimonce at redhat.com
> Sent: Tuesday, January 21, 2014 4:11:24 PM
> Subject: [Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs -
> Build # 6308 - Still Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/
> Build Number: 6308
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change
> 
> -------------------------------------
> Changes Since Last Success:
> -------------------------------------
> Changes for Build #6301
> [Moti Asayag] engine: Extract AddNetworksByLabelParametersBuilder
> 
> [Moti Asayag] engine: Support attaching two labeled networks to a cluster
> 
> [Moti Asayag] engine: Extract RemoveNetworksByLabelParametersBuilder
> 
> [Moti Asayag] engine: Support detaching two labeled networks from a cluster
> 
> [Lior Vernia] webadmin: Replaced "Profiles" by "vNIC Profiles"
> 
> 
> Changes for Build #6302
> [Sergey Gotliv] engine, dao: Introduce ISCSI Bond entity, tables and dao
> 
> [Sergey Gotliv] engine: Introduce commands to manage iscsi bonds entities
> 
> [Sergey Gotliv] engine: Setup multiple iscsi sessions with the iscsi target
> 
> 
> Changes for Build #6303
> [Sergey Gotliv] webadmin: Allow to configure ISCSI multipathing in the dc
> context
> 
> [Martin Perina] tools: Adds more validations to MAIL_PORT in notifier
> 
> [Moti Asayag] engine: Fix findbugs warnings about Map values iteration
> 
> [Lior Vernia] webadmin: Hide content widget of boot protocol label
> 
> 
> Changes for Build #6304
> [Lior Vernia] webadmin: Integrate VM icon into Add/Edit Network dialog
> 
> 
> Changes for Build #6305
> [Alexander Wels] webadmin: Double click collapse system tree
> 
> 
> Changes for Build #6306
> [Daniel Erez] restapi: del storage conn if domain creation fails
> 
> 
> Changes for Build #6307
> [Moti Asayag] restapi: Preserve labels when setup networks is sent
> 
> 
> Changes for Build #6308
> [Federico Simoncelli] core: set local storage domain format
> 
> 
> 
> 
> -----------------
> Failed Tests:
> -----------------
> No tests ran.
> 
> 
> _______________________________________________
> Engine-patches mailing list
> Engine-patches at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-patches
>