[Kimchi-devel] [PATCH] Issue#348: Add loading icon when nfs mount is in progress

[Royce Lv]

On 2014年05月23日 17:35, Hongliang Wang wrote:
>
> On 05/23/2014 04:18 PM, lvroyce at linux.vnet.ibm.com wrote:
>> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>>
>> Add loading icon to indicate nfs mount in progress,
>> when error or normal response returns,
>> close create window.
>>
>> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
>> ---
>>   ui/js/src/kimchi.storagepool_add_main.js | 2 ++
>>   ui/pages/storagepool-add.html.tmpl       | 6 ++++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/ui/js/src/kimchi.storagepool_add_main.js 
>> b/ui/js/src/kimchi.storagepool_add_main.js
>> index 86dbe7f..6b77bd8 100644
>> --- a/ui/js/src/kimchi.storagepool_add_main.js
>> +++ b/ui/js/src/kimchi.storagepool_add_main.js
>> @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () {
>>           kimchi.message.error.code('KCHPOOL6005E');
>>           return false;
>>       }
>> +    $('#nfs-mount-loading').removeClass('hidden');
>>       return true;
>>   };
>>
>> @@ -295,6 +296,7 @@ kimchi.addPool = function(event) {
>>                   kimchi.window.close();
>>               }, function(err) {
>>                   kimchi.message.error(err.responseJSON.reason);
>> +                kimchi.window.close();
>>               });
>>           }
>>       }
>> diff --git a/ui/pages/storagepool-add.html.tmpl 
>> b/ui/pages/storagepool-add.html.tmpl
>> index 977db66..b0bc36d 100644
>> --- a/ui/pages/storagepool-add.html.tmpl
>> +++ b/ui/pages/storagepool-add.html.tmpl
>> @@ -91,6 +91,12 @@
>>                                       </ul>
>>                                   </div>
>>                               </div>
>> +                            <div class="hidden" id="nfs-mount-loading">
>> +                                <p class="text-help">
>
>> + $_("Server trying mount nfs export path...")
> I'm not sure what message should be shown here. Maybe:
>
> $_("Trying to mount NFS export path. It may take several seconds.")
ACK
>
> The rest part of this patch is OK.
>> + <img src = "../images/theme-default/loading.gif" />
>> +                                </p>
>> +                            </div>
>>                           </div>
>>                       </section>
>>                   </div>
>