[Kimchi-devel] [PATCH] Remove '.iso' extension checking when create new template

[Rodrigo Trujillo]

Thanks Sheldon!
I think we can remove this checking too, for consistency.
Will send new patch

On 05/27/2014 06:16 AM, Sheldon wrote:
> still one place check the name suffix with iso in UI code.
> It is kimchi.is_iso_file
>
> On 05/24/2014 02:08 AM, Rodrigo Trujillo wrote:
>> Libvirt accepts iso files with names that do not end with '.iso'
>> extension. Also, Kimchi discovers ISOs stored in storagepools by the
>> file format, it does not care about file name.
>> This patch removes the .iso checking from API.json schema, then files
>> ending with '.iso.1', '.iso.bkp' or any other, can be used.
>>
>> Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
>> ---
>>   src/kimchi/API.json | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/kimchi/API.json b/src/kimchi/API.json
>> index b9d371a..44a1439 100644
>> --- a/src/kimchi/API.json
>> +++ b/src/kimchi/API.json
>> @@ -361,7 +361,7 @@
>>                   "cdrom": {
>>                       "description": "Path for cdrom",
>>                       "type": "string",
>> -                    "pattern": 
>> "^((/)|(http)[s]?:|[t]?(ftp)[s]?:)+.*([.]iso)$",
>> +                    "pattern": "^((/)|(http)[s]?:|[t]?(ftp)[s]?:)+.*$",
>>                       "required": true,
>>                       "error": "KCHTMPL0014E"
>>                   },
>> @@ -532,7 +532,7 @@
>>                   "cdrom": {
>>                       "description": "Path for cdrom",
>>                       "type": "string",
>> -                    "pattern": 
>> "^((/)|(http)[s]?:|[t]?(ftp)[s]?:)+.*([.]iso)$",
>> +                    "pattern": "^((/)|(http)[s]?:|[t]?(ftp)[s]?:)+.*$",
>>                       "error": "KCHTMPL0014E"
>>                   },
>>                   "disks": {
>
>