[Kimchi-devel] [PATCH V2] [Ginger-Base 0/1] Issue 728 - Processor Info in s390 architecture

[Suresh Babu Angadi]

On 11/26/2015 05:10 AM, Aline Manera wrote:
>
> Hi Suresh,
>
> The patch looks good but there is a test failing due those changes. 
> Could you, please, fix it and resend?
Hi Aline,
Will send v3 with the fix.
>
> ======================================================================
> FAIL: test_hostinfo (test_host.HostTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "test_host.py", line 77, in test_hostinfo
>     self.assertEquals(psutil.TOTAL_PHYMEM, info['memory'])
> AssertionError: 8048709632L != {u'offline': 0, u'online': 8048709632}
>
> ----------------------------------------------------------------------
>
> You also need to update the UI code to display the right value for 
> memory and CPUs.
> With this patch it is current displaying [object Object].
Per chandra's email, to avoid conflicts, the UI changes will be part of 
his patch set.
>
>
>
> On 24/11/2015 09:59, sureshab at linux.vnet.ibm.com wrote:
>> From: Suresh Babu Angadi<sureshab at in.ibm.com>
>>
>> V1 to V2 changes:
>> Changed cpus and memory object to be same across all platforms(aline)
>> Changed API.md and lookup as per review comments(aline & abhiram)
>>
>> As per RFC mail thread -
>>       [Kimchi-devel] RFC - #728 - Processor Info in s390 architecture
>> this patch set adds functionality in back-end to add
>> architecture, and host name(for all architecture),
>> split CPUs to online and offline(x86, s390x),
>> additional virtualization details(for s390x)
>>
>> Note: Subsequent patch set for UI changes will follow
>>        to accommodate these changes
>>
>> Test Cases Executed:
>> ====================
>> 1) On x86 machine(ppc o/p will be similar to x86):
>> curl -k -u suresh -H "Content-Type: application/json" -H "Accept: application/json" -X GET 'https://127.0.0.1:8001/plugins/gingerbase/host'
>> {
>>    "os_distro":"Fedora",
>>    "cpus":{
>>      "offline":0,
>>      "online":4
>>    },
>>    "cpu_model":"Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz",
>>    "os_version":"21",
>>    "host":"localhost.localdomain",
>>    "os_codename":"Twenty One",
>>    "architecture":"x86_64",
>>    "memory":{
>>      "offline":0,
>>      "online":7933902848
>>    }
>> }
>>
>> 2) On s390x machine:
>> curl -k -u root -H "Content-Type: application/json" -H "Accept: application/json" -X GET 'https://127.0.0.1:8001/plugins/gingerbase/host'
>> {
>>    "os_distro":"KVM for IBM z Systems",
>>    "cpus":{
>>      "shared":2,
>>      "offline":2,
>>      "dedicated":0,
>>      "online":2
>>    },
>>    "cpu_model":"IBM/2827/743 H43",
>>    "os_version":"1.1.1",
>>    "host":"zfwcec103",
>>    "os_codename":"Z",
>>    "architecture":"s390x",
>>    "memory":{
>>      "offline":2147483648,
>>      "online":2147483648
>>    },
>>    "virtualization":{
>>      "lpar_name":"CSTLIN1",
>>      "hypervisor":"PR/SM",
>>      "lpar_number":55,
>>      "hypervisor_vendor":"IBM"
>>    }
>> }
>>
>>
>> Suresh Babu Angadi (1):
>>    Fix for issue 728: processor info displays blank for system z
>>    this patch set also adds additional capability:
>>    retrieving architecture and host name (for all architecture)
>>    split CPUs to show online and offline cpus also
>>      includes shared and dedicated cpus for s390x
>>    split memory to show online and offline
>>    additional virtualization details(for s390x):
>>    virtualization will have hypervisor details and lpar details
>>
>>   src/wok/plugins/gingerbase/docs/API.md        |  18 +-
>>   src/wok/plugins/gingerbase/i18n.py            |   1 +
>>   src/wok/plugins/gingerbase/lscpu.py           |  60 ++++++
>>   src/wok/plugins/gingerbase/model/host.py      | 259 ++++++++++++++++++++++----
>>   src/wok/plugins/gingerbase/tests/test_host.py |  12 +-
>>   5 files changed, 307 insertions(+), 43 deletions(-)
>>
>

-- 
Regards,
Suresh Babu Angadi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/34eee857/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 14778 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/34eee857/attachment.jpe>