[Kimchi-devel] [PATCH v2] [WoK 0/2] eliminate code repetition when fetching model instances

Lucio Correia luciojhc at linux.vnet.ibm.com
Fri Aug 12 13:24:58 UTC 2016


Nice job!

Reviewed-By: Lucio Correia <luciojhc at linux.vnet.ibm.com>

On 12-08-2016 07:42, dhbarboza82 at gmail.com wrote:
> From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
>
> v2:
> - added support for loading model instances that receive
> no keyword arguments in the constructor.
>
> To avoid code duplication across WoK plug-ins, this patch
> encapsulates the core logic in all 'model.py' files in two
> utility functions in wok/utils.py to be used by all plug-ins.
>
> An example of usage is given in model.py from WoK.
>
>
> Daniel Henrique Barboza (2):
>   wok/utils.py: adding utility 'get model instances' methods
>   model.py: use the new 'get_all_model_instances' utils function
>
>  src/wok/model/model.py | 22 ++----------------
>  src/wok/utils.py       | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 65 insertions(+), 20 deletions(-)
>


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil




More information about the Kimchi-devel mailing list