Projects missing safe dir config in COPR
Hi, I scanned the current projects and AFAICT these are the active projects that don't have builds configured properly. Please add "git config --global --add safe.directory ..." to the COPR makefile Otherwise COPR build may not work at all or (worse) they build something wrong. Thanks, michal imgbased ioprocess mom ovirt-ansible-collection ovirt-cockpit-sso ovirt-engine-api-metamodel ovirt-engine-api-model ovirt-engine-wildfly ovirt-hosted-engine-ha ovirt-hosted-engine-setup ovirt-lldp-labeler ovirt-log-collector ovirt-node-ng ovirt-openvswitch ovirt-setup-lib ovirt-vmconsole python-ovirt-engine-sdk4
Hi Michal, Why do you think it's required? And for which repos and which directories? Thanks in advance, On Mon, Jun 13, 2022 at 1:39 PM Michal Skrivanek <mskrivan@redhat.com> wrote:
Hi, I scanned the current projects and AFAICT these are the active projects that don't have builds configured properly. Please add "git config --global --add safe.directory ..." to the COPR makefile Otherwise COPR build may not work at all or (worse) they build something wrong.
Thanks, michal
imgbased ioprocess mom ovirt-ansible-collection ovirt-cockpit-sso ovirt-engine-api-metamodel ovirt-engine-api-model ovirt-engine-wildfly ovirt-hosted-engine-ha ovirt-hosted-engine-setup ovirt-lldp-labeler ovirt-log-collector ovirt-node-ng ovirt-openvswitch ovirt-setup-lib ovirt-vmconsole python-ovirt-engine-sdk4
-- Lev Veyde Senior Software Engineer, RHCE | RHCVA | MCITP Red Hat Israel <https://www.redhat.com> lev@redhat.com | lveyde@redhat.com <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
On Mon, Jun 13, 2022 at 9:17 AM Lev Veyde <lveyde@redhat.com> wrote:
Hi Michal,
Why do you think it's required?
TL;DR - comes down to a git CVE where git doesn't like when the git repo owner is not the same as the user running git commands. More details: https://github.com/oVirt/ovirt-web-ui/pull/1588#issue-1229894007
And for which repos and which directories?
Thanks in advance,
On Mon, Jun 13, 2022 at 1:39 PM Michal Skrivanek <mskrivan@redhat.com> wrote:
Hi, I scanned the current projects and AFAICT these are the active projects that don't have builds configured properly. Please add "git config --global --add safe.directory ..." to the COPR makefile Otherwise COPR build may not work at all or (worse) they build something wrong.
Thanks, michal
imgbased ioprocess mom ovirt-ansible-collection ovirt-cockpit-sso ovirt-engine-api-metamodel ovirt-engine-api-model ovirt-engine-wildfly ovirt-hosted-engine-ha ovirt-hosted-engine-setup ovirt-lldp-labeler ovirt-log-collector ovirt-node-ng ovirt-openvswitch ovirt-setup-lib ovirt-vmconsole python-ovirt-engine-sdk4
--
Lev Veyde
Senior Software Engineer, RHCE | RHCVA | MCITP
Red Hat Israel
lev@redhat.com | lveyde@redhat.com <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> _______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-leave@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RIX2YNFPYCVFND...
-- Scott Dickerson Senior Software Engineer RHV-M Engineering - UX Team Red Hat, Inc
On Mon, Jun 13, 2022 at 1:39 PM Michal Skrivanek <mskrivan@redhat.com> wrote:
Hi, I scanned the current projects and AFAICT these are the active projects that don't have builds configured properly. Please add "git config --global --add safe.directory ..." to the COPR makefile Otherwise COPR build may not work at all or (worse) they build something wrong.
For example way to fix this issue see: https://github.com/oVirt/vdsm/commit/64873df82480006fce743baa89b83b94c41e53e... https://github.com/oVirt/ovirt-imageio/commit/a72c680782584db17597dd3116e0a1...
Thanks, michal
imgbased ioprocess
Fixed in https://github.com/oVirt/ioprocess/pull/2
mom ovirt-ansible-collection ovirt-cockpit-sso ovirt-engine-api-metamodel ovirt-engine-api-model ovirt-engine-wildfly ovirt-hosted-engine-ha ovirt-hosted-engine-setup ovirt-lldp-labeler ovirt-log-collector ovirt-node-ng ovirt-openvswitch ovirt-setup-lib ovirt-vmconsole python-ovirt-engine-sdk4
Nir
participants (4)
-
Lev Veyde -
Michal Skrivanek -
Nir Soffer -
Scott Dickerson