10:07 p.m.
Thanks, Yun Xin!
The UI looks good for me.
Just a question/comment/doubt:
The plus icon is to attach a new device, right?
I suppose it does not open a new dialog, right? ie, when clicking on it
the operation will be performed without any other user input?
On 07/31/2014 09:20 AM, Yu Xin Huo wrote:
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel
10:49 p.m.
On 31-07-2014 17:07, Aline Manera wrote:
Just a question/comment/doubt:
The plus icon is to attach a new device, right?
So we should be consistent and not
use that same icon.
Every "+" icon in Kimchi means adding/creating something (e.g. creating
a guest, a template, a network, adding a new storage, NIC). If this new
button doesn't add/create something, we should use a different image.
One could easily guess that this "+" button would add a new PCI device,
which is not the case.
1:42 a.m.
On 07/31/2014 05:49 PM, Crístian Viana wrote:
On 31-07-2014 17:07, Aline Manera wrote:
> Just a question/comment/doubt:
> The plus icon is to attach a new device, right?
So we should be consistent and not use that same icon.
Every "+" icon in Kimchi means adding/creating something (e.g.
creating a guest, a template, a network, adding a new storage, NIC).
If this new button doesn't add/create something, we should use a
different image. One could easily guess that this "+" button would add
a new PCI device, which is not the case.
By attachment, I mean a new PCI device will be added to the guest which
is the same case of a new storage.
1:15 p.m.
On 8/1/2014 7:42 AM, Aline Manera wrote:
On 07/31/2014 05:49 PM, Crístian Viana wrote:
> On 31-07-2014 17:07, Aline Manera wrote:
>> Just a question/comment/doubt:
>> The plus icon is to attach a new device, right?
> So we should be consistent and not use that same icon.
>
> Every "+" icon in Kimchi means adding/creating something (e.g.
> creating a guest, a template, a network, adding a new storage, NIC).
> If this new button doesn't add/create something, we should use a
> different image. One could easily guess that this "+" button would
> add a new PCI device, which is not the case.
By attachment, I mean a new PCI device will be added to the guest
which is the same case of a new storage.
Exactly correct. Aline, your explanation is consistent with
virt-manager UI.
1:13 p.m.
On 8/1/2014 4:49 AM, Crístian Viana wrote:
On 31-07-2014 17:07, Aline Manera wrote:
> Just a question/comment/doubt:
> The plus icon is to attach a new device, right?
So we should be consistent and not use that same icon.
Every "+" icon in Kimchi means adding/creating something (e.g.
creating a guest, a template, a network, adding a new storage, NIC).
If this new button doesn't add/create something, we should use a
different image. One could easily guess that this "+" button would add
a new PCI device, which is not the case.
It is just add/remove device to vm. refer
to virt-manager below.
1:10 p.m.
On 8/1/2014 4:07 AM, Aline Manera wrote:
Thanks, Yun Xin!
The UI looks good for me.
Just a question/comment/doubt:
The plus icon is to attach a new device, right?
correct.
I suppose it does not open a new dialog, right? ie, when clicking on
it the operation will be performed without any other user input?
correct. when
click on the '+' button, the pci device will be added to
vm without any other user input and the '+' button will be changed to
'-'.
On 07/31/2014 09:20 AM, Yu Xin Huo wrote:
>
>
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
3566
days inactive
3567
days old
6 comments
3 participants
participants (3)
-
Aline Manera -
Crístian Viana -
Yu Xin Huo