Arik Hadas has submitted this change and it was merged.
Change subject: core: minor refactoring in vm-analyzer
......................................................................
core: minor refactoring in vm-analyzer
1. In proceedDownVm, 'prevStatus' is always assigned with some value
now so no need to compare to 'Unassigned'.
2. Remove the arguments from handleVmOnDown and inMigrationTo methods.
3. Remove the argument from afterSuspendTreatment method.
4. Remove redundant null checks in proceedVmBeforeDeletion and
removeVmFromCache methods.
Change-Id: I4128fd29470ddcaeecc882f16ed5aa3e0e34a965
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 29 insertions(+), 30 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit
https://gerrit.ovirt.org/55630
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4128fd29470ddcaeecc882f16ed5aa3e0e34a965
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>