Change in ovirt-engine-sdk[sdk_4.0]: Avoid of reading fault response in case response body is empty
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Avoid of reading fault response in case response body is empty
......................................................................
Avoid of reading fault response in case response body is empty
In case there is 404 returned from API, we try to parse response body,
but in this case it's useless and returned exception previously,
this patch changes it, so we don't parse response in case it's empty.
Change-Id: Ia3c6e7bee7a1926cc007db9477640d675487dbe6
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 1be141f8903117ab5e4535d7c7de9cd16a4753ce)
---
M sdk/lib/ovirtsdk4/service.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c6e7bee7a1926cc007db9477640d675487dbe6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix overwriting originalClusterVersion
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix overwriting originalClusterVersion
......................................................................
core: Fix overwriting originalClusterVersion
Fix of overwriting originalClusterVersion in SnapshotManager.
The VmBase.originalClusterVersion is persisted in OVF as CLUSTER_COMPATIBILITY_VERSION
and points to the cluster version the snapshot was taken in.
Later on, the value is used in UI to check whether the snapshot
with memory can be properly restored.
Change-Id: Ib6f93e9ef91f283ed5e7ebaea75b0351bbd0ed85
Bug-Url: https://bugzilla.redhat.com/1356172
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
3 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63081
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6f93e9ef91f283ed5e7ebaea75b0351bbd0ed85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: Mark instance image as changed in new and attach
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Mark instance image as changed in new and attach
......................................................................
webadmin: Mark instance image as changed in new and attach
Change I998e8c573c8afaf45668729cf15fb0ebe3edbad5 introduced a change where
disk update for instance images will be invoked only upon edit, however,
this made new and attach disk actions to be skipped as well.
This patch adds the indication of a change to create and attach disk as
well so the will not be skipped.
Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c
Bug-Url: https://bugzilla.redhat.com/1371164
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Ignore failures fetching additional disk data
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Ignore failures fetching additional disk data
......................................................................
restapi: Ignore failures fetching additional disk data
When disks are retrieved using version 3 of the API additional data is
required, like the disk attachments. If the user doesn't have permission for
the additional data then the complete operation fails. This is a problem for
users that may not have permission for that additional data. In order to avoid
that this patch changes the API so that failures to retrieve the additional
data are just ignored.
Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87
Bug-Url: https://bugzilla.redhat.com/1368552
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit d4c500b16549b74839220c8a44b35de4ba9da6ee)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java
3 files changed, 60 insertions(+), 15 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63076
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Mark instance image as changed in new and attach
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Mark instance image as changed in new and attach
......................................................................
webadmin: Mark instance image as changed in new and attach
Change I998e8c573c8afaf45668729cf15fb0ebe3edbad5 introduced a change where
disk update for instance images will be invoked only upon edit, however,
this made new and attach disk actions to be skipped as well.
This patch adds the indication of a change to create and attach disk as
well so the will not be skipped.
Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c
Bug-Url: https://bugzilla.redhat.com/1371164
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63077
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I093ccc18a4ab70b4f2a5bcd3ef46abeb41cee55c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: restapi: Don't add V3 guest IP to links
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't add V3 guest IP to links
......................................................................
restapi: Don't add V3 guest IP to links
Currently the V3 compatibility layer tries to add the guest IP to all
the returned objects of type "vm". That is wrong, as links, for example,
shouldn't include such information. To solve the problem this patch
changes the API so that the population of the guest IP is performed only
for objects of type "vm" returned by the "list", "get", and "update"
operations of the services that manage virtual machines.
Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda
Related: https://bugzilla.redhat.com/1368552
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java
4 files changed, 71 insertions(+), 57 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62769
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: restapi: Don't add V3 disk attachment details to links
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't add V3 disk attachment details to links
......................................................................
restapi: Don't add V3 disk attachment details to links
Currently the V3 compatibility layer tries to add the attachment details
(bootable, etc) to all the returned objects of type "disk". That is
wrong, as links, for example, shoundn't include such information. To
solve the problem this patch changes the API so that the population of
these details is performed only for objects of type "disk" returned by
the "list", "get", and "update" operations of the services that manage
virtual machine disks.
Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3
Related: https://bugzilla.redhat.com/1368552
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java
4 files changed, 49 insertions(+), 79 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: Adding ovirt-hosted-engine-ha std-ci jobs
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Adding ovirt-hosted-engine-ha std-ci jobs
......................................................................
Adding ovirt-hosted-engine-ha std-ci jobs
Also removed create-rpms jobs for 4.0 and master and updated the
nightly publihers accordingly.
Adding check-patch, check merged and build-artifacts jobs
for ovirt-hosted-engine-ha
Change-Id: I70cffbe8d35397df9f6debfbdaabb52470816206
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml
A jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_standard.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
4 files changed, 37 insertions(+), 61 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for merge
Sharon Naftaly: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70cffbe8d35397df9f6debfbdaabb52470816206
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-hosted-engine-ha[v2.0.z]: Add std-ci scripts and related repos and packages files
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add std-ci scripts and related repos and packages files
......................................................................
Add std-ci scripts and related repos and packages files
Change-Id: Ic605d3d773a0e86bb2e41861673f22c5371b5d43
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
A automation/build-artifacts-manual.packages
A automation/build-artifacts-manual.repos
A automation/build-artifacts-manual.repos.el7
A automation/build-artifacts-manual.sh
A automation/build-artifacts.packages
A automation/build-artifacts.repos
A automation/build-artifacts.repos.el7
A automation/build-artifacts.sh
A automation/check-merged.packages
A automation/check-merged.repos
A automation/check-merged.repos.el7
A automation/check-merged.sh
A automation/check-patch.packages
A automation/check-patch.repos
A automation/check-patch.repos.el7
A automation/check-patch.sh
16 files changed, 106 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62907
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic605d3d773a0e86bb2e41861673f22c5371b5d43
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.0.z
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: webadmin: don't cast from Guid to StorageDomain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: don't cast from Guid to StorageDomain
......................................................................
webadmin: don't cast from Guid to StorageDomain
This patch removes a wrong cast from the return type of getEntity()
(Guid) to StorageDomain, and replaces it with a cast to Guid.
Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8
Bug-Url: https://bugzilla.redhat.com/1371304
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/63075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months