Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Improve UI Plugin tab API ...................................................................... webadmin: Improve UI Plugin tab API GWTP/infrastructure changes --------------------------- 1. Introduced AbstractTabPresenter as the parent presenter for AbstractMainTabPresenter and AbstractSubTabPresenter. 2. Adding custom action buttons to existing main/sub tabs is now done via AddTabActionButtonEvent handled by AbstractTabPresenter via @ProxyEvent. EventBus provides loose coupling between caller (PluginUiFunctions) and handler (AbstractTabPresenter). 3. Minor improvements in ActionButtonDefinition interface: - isAccessible() now accepts selected items for consistency with ActionButtonInterface.isAccessible() - getUniqueId() can now return null (no ID available) - getToolTip() renamed to getButtonToolTip() - getCustomToolTip() renamed to getMenuItemToolTip() 4. Updated AbstractActionPanel according to changes in ActionButtonDefinition interface. 5. Introduced AbstractButtonDefinition as base implementation of ActionButtonDefinition interface. This class is used for both existing buttons (UiCommandButtonDefinition) and custom buttons (extend AbstractButtonDefinition directly). UI Plugin API changes --------------------- 6. Revamped EntityType enum, added missing entity types: - Network - Pool - GlusterVolume - Provider - User - Quota - Event 7. addSubTab and addMainTabActionButton API now support all entity types. 8. Introduced addSubTabActionButton API with following signature: addSubTabActionButton( mainTabEntityTypeName, // Which main tab? subTabEntityTypeName, // Which sub tab? label, actionButtonInterface) For now, subTabEntityTypeName supports only 'Event' value. 9. Updated EntityObject with basic property mappings for new entity types. 10. Added <EntityType>SelectionChange event handler functions for new entity types Change-Id: I2f3e33844693a08352cc54b60b05b3f6ac5eb816 Bug-Url: https://bugzilla.redhat.com/953989 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com&gt; --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabPresenter.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AddTabActionButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabFormView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabTreeWidgetView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/ActionButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiMenuBarButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/HasActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityType.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterPolicyPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/ReportActionsHelper.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/action/WebAdminButtonDefinition.java 28 files changed, 759 insertions(+), 486 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f3e33844693a08352cc54b60b05b3f6ac5eb816 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com&gt; Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt; Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server