[PATCH] Update License Statement
by Hongliang Wang
Removed "Authors" section.
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/css/theme-default/repository-add.css | 5 +----
ui/css/theme-default/repository-edit.css | 5 +----
ui/js/src/kimchi.repository_add_main.js | 5 +----
ui/pages/repository-add.html.tmpl | 5 +----
4 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/ui/css/theme-default/repository-add.css b/ui/css/theme-default/repository-add.css
index ab28ee1..f97f8dd 100644
--- a/ui/css/theme-default/repository-add.css
+++ b/ui/css/theme-default/repository-add.css
@@ -1,10 +1,7 @@
/*
* Project Kimchi
*
- * Copyright IBM, Corp. 2014
- *
- * Authors:
- * Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
+ * Copyright IBM, Corp. 2013-2014
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
diff --git a/ui/css/theme-default/repository-edit.css b/ui/css/theme-default/repository-edit.css
index 98995a9..16342d7 100644
--- a/ui/css/theme-default/repository-edit.css
+++ b/ui/css/theme-default/repository-edit.css
@@ -1,10 +1,7 @@
/*
* Project Kimchi
*
- * Copyright IBM, Corp. 2014
- *
- * Authors:
- * Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
+ * Copyright IBM, Corp. 2013-2014
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
diff --git a/ui/js/src/kimchi.repository_add_main.js b/ui/js/src/kimchi.repository_add_main.js
index d0e1121..9197b7b 100644
--- a/ui/js/src/kimchi.repository_add_main.js
+++ b/ui/js/src/kimchi.repository_add_main.js
@@ -1,10 +1,7 @@
/*
* Project Kimchi
*
- * Copyright IBM, Corp. 2014
- *
- * Authors:
- * Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
+ * Copyright IBM, Corp. 2013-2014
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
diff --git a/ui/pages/repository-add.html.tmpl b/ui/pages/repository-add.html.tmpl
index 73ff415..522043d 100644
--- a/ui/pages/repository-add.html.tmpl
+++ b/ui/pages/repository-add.html.tmpl
@@ -1,10 +1,7 @@
#*
* Project Kimchi
*
- * Copyright IBM, Corp. 2014
- *
- * Authors:
- * Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
+ * Copyright IBM, Corp. 2013-2014
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
--
1.8.1.4
10 years, 3 months
[PATCH] model.templates: setting ISO ACL in template creation
by Daniel Henrique Barboza
Sometimes after a deep scan the template creation fails due to
permission issues with the selected ISO. This patch sets the ACL
(if necessary) of the ISO to avoid this scenario.
Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com>
---
src/kimchi/model/templates.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/kimchi/model/templates.py b/src/kimchi/model/templates.py
index 9278cdc..a792a17 100644
--- a/src/kimchi/model/templates.py
+++ b/src/kimchi/model/templates.py
@@ -27,7 +27,7 @@ from kimchi.exception import InvalidOperation, InvalidParameter
from kimchi.exception import NotFoundError, OperationFailed
from kimchi.kvmusertests import UserTests
from kimchi.utils import pool_name_from_uri
-from kimchi.utils import probe_file_permission_as_user
+from kimchi.utils import probe_file_permission_as_user, run_setfacl_set_attr
from kimchi.vmtemplate import VMTemplate
@@ -44,9 +44,7 @@ class TemplatesModel(object):
user = UserTests().probe_user()
ret, excp = probe_file_permission_as_user(iso, user)
if ret is False:
- raise InvalidParameter('KCHISO0008E',
- {'filename': iso, 'user': user,
- 'err': excp})
+ run_setfacl_set_attr(iso)
conn = self.conn.get()
pool_uri = params.get(u'storagepool', '')
--
1.8.3.1
10 years, 3 months
[PATCH 0/2] Support async task query classification
by Aline Manera
This patch set allows querying Tasks by their target_uri which is a resource
URI. That way every user can get the same view from that one who started the
Task.
Aline Manera (2):
Expose target_uri on Task resource
Update current code to report target_uri while creating a Task
docs/API.md | 1 +
src/kimchi/control/tasks.py | 4 +---
src/kimchi/mockmodel.py | 6 ++++--
src/kimchi/model/debugreports.py | 3 ++-
src/kimchi/model/host.py | 3 ++-
src/kimchi/model/storagepools.py | 4 ++--
tests/test_rest.py | 14 +++++++++++---
7 files changed, 23 insertions(+), 12 deletions(-)
--
1.9.3
10 years, 3 months
[PATCH 0/2] Change storage volume creation to async tasks
by lvroyce＠linux.vnet.ibm.com
From: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
v1>v2,
Change according to Aline's comments,
Use list to track param index to avoid iteration.
This is inspired by Cristian's patch.
Royce Lv (2):
Storage volume upload: Dispatch volume create to right handler
Storage volume upload: Change storagevolumes to AsyncCollection
src/kimchi/control/storagevolumes.py | 4 ++--
src/kimchi/i18n.py | 2 ++
src/kimchi/model/storagevolumes.py | 22 ++++++++++++++++++++--
tests/test_model.py | 8 ++++++--
tests/test_rest.py | 9 ++++++---
5 files changed, 36 insertions(+), 9 deletions(-)
--
1.8.3.2
10 years, 3 months
[PATCH 0/2 V2] Change storage volume creation to async tasks
by Aline Manera
V1 -> V2:
- Fix "make check-local" issues
- Update mockmodel to also return a Task while creating a storage volume
- Update the jsonschema and API.md
Royce Lv (2):
Storage volume upload: Dispatch volume create to right handler
Storage volume upload: Change storagevolumes to AsyncCollection
docs/API.md | 1 +
src/kimchi/API.json | 6 ++++++
src/kimchi/control/storagevolumes.py | 4 ++--
src/kimchi/i18n.py | 3 +++
src/kimchi/mockmodel.py | 22 +++++++++++++++++++++-
src/kimchi/model/storagevolumes.py | 26 ++++++++++++++++++++++++--
tests/test_model.py | 8 ++++++--
tests/test_rest.py | 28 ++++++++++++++++------------
8 files changed, 79 insertions(+), 19 deletions(-)
--
1.9.3
10 years, 3 months
[PATCH V2] UI bug fix: Properly display storage volumes on Storage tab
by Aline Manera
While selecting an active storage pool, the storage volumes in it should
be listed.
But commit 1fb4257f changed "hide-content" CSS class to "display: none!important"
which is preveting the storage volumes to be displayed through
.slideDown() function.
Set "style=display:none" to the volumes div to fix it.
Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com>
---
ui/css/theme-default/storage.css | 2 +-
ui/pages/tabs/storage.html.tmpl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/css/theme-default/storage.css b/ui/css/theme-default/storage.css
index ab92de2..f635c2f 100644
--- a/ui/css/theme-default/storage.css
+++ b/ui/css/theme-default/storage.css
@@ -309,7 +309,7 @@
.volumes {
background: #73716F;
width: 1004px;
- display: inline-block;
+ display: none;
margin-top: 10px;
border: 1px solid rgb(204, 204, 204);
}
diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.tmpl
index 34ccd21..87205bd 100644
--- a/ui/pages/tabs/storage.html.tmpl
+++ b/ui/pages/tabs/storage.html.tmpl
@@ -91,7 +91,7 @@
<div class="arrow-down"></div>
</div>
</div>
- <div class="volumes hide-content">
+ <div class="volumes">
<div id="volume{name}" class="volumeslist" data-name="{name}" ></div>
<div class="clear"></div>
</div>
--
1.9.3
10 years, 3 months
[PATCH] UI bug fix: Properly display storage volumes on Storage tab
by Aline Manera
While selecting an active storage pool, the storage volumes in it should
be listed.
But commit 1fb4257f changed "hide-content" CSS class to "display: none!important"
which is preveting the storage volumes to be displayed through
.slideDown() function.
Set "style=display:none" to the volumes div to fix it.
Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com>
---
ui/pages/tabs/storage.html.tmpl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.tmpl
index 34ccd21..f46632a 100644
--- a/ui/pages/tabs/storage.html.tmpl
+++ b/ui/pages/tabs/storage.html.tmpl
@@ -91,7 +91,7 @@
<div class="arrow-down"></div>
</div>
</div>
- <div class="volumes hide-content">
+ <div class="volumes" style="display:none">
<div id="volume{name}" class="volumeslist" data-name="{name}" ></div>
<div class="clear"></div>
</div>
--
1.9.3
10 years, 3 months
[PATCH 0/5] Discover Kimchi peers using openSLP
by Aline Manera
I haven't add the federation info to /config/capabilities because I thought in
always display the same message when any peers were found.
"No peers found.
More information at: <federation-help-page>"
Then we can use README-federation as the federation help page.
What do you think?
Aline Manera (5):
Update kimchi.config values according to command line input
Delete http_port from /config API as it is not in use anymore
Add federation option to Kimchi config file
Discover Kimchi peers using openSLP
Add documentation on how to enable federation on Kimchi
docs/API.md | 1 -
docs/README-federation.md | 27 +++++++++++++++++++++
src/kimchi.conf.in | 4 +++
src/kimchi/config.py.in | 1 +
src/kimchi/control/peers.py | 29 ++++++++++++++++++++++
src/kimchi/mockmodel.py | 11 ++++++---
src/kimchi/model/config.py | 3 +--
src/kimchi/model/peers.py | 59 +++++++++++++++++++++++++++++++++++++++++++++
src/kimchi/server.py | 1 -
src/kimchid.in | 36 +++++++++++++++++----------
tests/test_rest.py | 7 +++++-
11 files changed, 158 insertions(+), 21 deletions(-)
create mode 100644 docs/README-federation.md
create mode 100644 src/kimchi/control/peers.py
create mode 100644 src/kimchi/model/peers.py
--
1.9.3
10 years, 3 months
[PATCH V2] Guest storage: fix volume format overwrite
by Aline Manera
V1 -> V2:
- Add qcow and vmdk as supported format to storage volume
Royce Lv (1):
Guest storage: fix volume format overwrite
src/kimchi/model/vmstorages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
1.9.3
10 years, 3 months
Mechanism for guest edits
by Brent Baude
Folks,
I'm about to send a patch to you guys that:
1) adds "serial" as a graphics type
2) allows you to edit the graphics type on a cold guest
In doing so and talking with Adam and Aline, it seems that a rework of
how the guest's xml is edited is in order. When you edit a template,
for example, the whole templates xml is basically re-instantiated and
only the values that kimchi cares about is added. The rest libvirt
fills in.
The editing of guest xmls differs from that mechanism. Right now the
actual xml is edited and resubmitted. If you think about editing
components of a guest (think about changing graphics types), you can see
where long-term there is an increased opportunity for the xml to become
complicated and maybe even incorrect. XML creep if you will.
So, we are thinking that the cold guest edition should more closely
follow how the template works, where critical parts that kimchi has
fields for is inserted and libvirt does the rest of the work. This will
also allow for future growth/change where new components are added.
I'll likely start a branch for it and get started on this. In the
meanwhile, I'll submit my graphics patches for a start.
Brent
10 years, 3 months
